content/renderer/media/media_stream_renderer_factory_impl.h - Issue 2005053006: Cleanup naming issue with content::VideoFrameProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_renderer_factory_impl.h

Issue 2005053006: Cleanup naming issue with content::VideoFrameProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/renderer/video_frame_provider.h ('k') | content/renderer/media/media_stream_renderer_factory_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_renderer_factory_impl.h

diff --git a/content/renderer/media/media_stream_renderer_factory_impl.h b/content/renderer/media/media_stream_renderer_factory_impl.h

index 33519efe73d1ed0c001259abfce65c74a1d5cb51..1305e08693245f031bc73fd20658f8f0da62503c 100644

--- a/content/renderer/media/media_stream_renderer_factory_impl.h

+++ b/content/renderer/media/media_stream_renderer_factory_impl.h

@@ -15,10 +15,10 @@ class MediaStreamRendererFactoryImpl : public MediaStreamRendererFactory {

MediaStreamRendererFactoryImpl();

~MediaStreamRendererFactoryImpl() override;

- scoped_refptr<VideoFrameProvider> GetVideoFrameProvider(

+ scoped_refptr<MediaStreamVideoRenderer> GetVideoRenderer(

const blink::WebMediaStream& web_stream,

const base::Closure& error_cb,

- const VideoFrameProvider::RepaintCB& repaint_cb,

+ const MediaStreamVideoRenderer::RepaintCB& repaint_cb,

const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,

const scoped_refptr<base::TaskRunner>& worker_task_runner,

media::GpuVideoAcceleratorFactories* gpu_factories) override;

« no previous file with comments | « content/public/renderer/video_frame_provider.h ('k') | content/renderer/media/media_stream_renderer_factory_impl.cc » ('j') | no next file with comments »