chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java - Issue 2005053002: WebAPKs: Open links which are outside of WebAPK scope in Chrome not in WebAPK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java

Issue 2005053002: WebAPKs: Open links which are outside of WebAPK scope in Chrome not in WebAPK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java

index 2f70f0bda63c1506d1e5fe2e295238d910c9f5a8..bcf8c7bb8ed3b7c0de3cb7db813942e469cd7d78 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java

@@ -10,6 +10,7 @@ import android.test.suitebuilder.annotation.SmallTest;

import org.chromium.base.ThreadUtils;

import org.chromium.chrome.browser.ChromeActivity;

+import org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImpl;

import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler;

import org.chromium.chrome.browser.externalnav.ExternalNavigationParams;

import org.chromium.chrome.test.ChromeActivityTestCaseBase;

@@ -67,7 +68,7 @@ public class InterceptNavigationDelegateTest extends ChromeActivityTestCaseBase<

class TestExternalNavigationHandler extends ExternalNavigationHandler {

public TestExternalNavigationHandler() {

- super(mActivity.getActivityTab());

+ super(new ExternalNavigationDelegateImpl(mActivity.getActivityTab(), null));

}

@Override