Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java

Issue 2005053002: WebAPKs: Open links which are outside of WebAPK scope in Chrome not in WebAPK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java
index ad6395bbaba1de81acf4d2c0ecebbd9afc22e325..0909efe8cd3f9c2a00e399c7ed9f523ab79a94e2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java
@@ -35,10 +35,15 @@ interface ExternalNavigationDelegate {
boolean isSpecializedHandlerAvailable(List<ResolveInfo> intent);
/**
- * Get the name of the package of the currently running activity so that incoming intents
- * can be identified as originating from this activity.
+ * @return Package name of the browser associated with the currently running activity.
Xi Han 2016/05/30 20:16:07 @return -> Returns?
*/
- String getPackageName();
+ String getBrowserPackageName();
+
+ /**
+ * @return Package name of the WebAPK associated with the currently running activity. Null if
Xi Han 2016/05/30 20:16:07 @return -> Returns?
+ * there is no associated WebAPK.
+ */
+ String getWebApkPackageName();
/**
* Start an activity for the intent. Used for intents that must be handled externally.
@@ -104,6 +109,12 @@ interface ExternalNavigationDelegate {
boolean isDocumentMode();
/**
+ * Launches the url in a new Chrome tab. This is useful if the page is being shown in a WebAPK.
+ * @param url The URL that Chrome should navigate to.
+ */
+ public void startChromeActivity(String url);
+
+ /**
* @return Default SMS application's package name. Null if there isn't any.
*/
String getDefaultSmsPackageName();

Powered by Google App Engine
This is Rietveld 408576698