Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm

Issue 2005013002: mac: ensure ui::Compositor exists for visible RWHVs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ensure in ctor and always in show Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/content_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm
index 5a8cfef1fcd4b349bc2384a0fd4d0a8ec6eaa414..42275cb527b81d64d54c3eca95a669d6fddedd31 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm
@@ -20,6 +20,7 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
+#include "ui/accelerated_widget_mac/window_resize_helper_mac.h"
#include "ui/base/layout.h"
using content::RenderWidgetHostViewMac;
@@ -133,6 +134,10 @@ TEST_F(RenderWidgetHostViewMacEditCommandHelperTest,
base::mac::ScopedNSAutoreleasePool pool;
+ base::MessageLoop message_loop;
+ ui::WindowResizeHelperMac::Get()->Init(
+ base::MessageLoop::current()->task_runner());
+
// Owned by its |cocoa_view()|, i.e. |rwhv_cocoa|.
RenderWidgetHostViewMac* rwhv_mac = new RenderWidgetHostViewMac(
render_widget, false);
@@ -157,11 +162,10 @@ TEST_F(RenderWidgetHostViewMacEditCommandHelperTest,
rwhv_cocoa.reset();
pool.Recycle();
- {
- // The |render_widget|'s process needs to be deleted within |message_loop|.
- base::MessageLoop message_loop;
- delete render_widget;
- }
+ // The |render_widget|'s process needs to be deleted within |message_loop|.
+ delete render_widget;
+
+ ui::WindowResizeHelperMac::Get()->ShutdownForTests();
}
// Test RenderWidgetHostViewMacEditCommandHelper::AddEditingSelectorsToClass
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/content_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698