Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2004993002: add a couple of casts. (Closed)

Created:
4 years, 7 months ago by bburns
Modified:
4 years, 7 months ago
Reviewers:
romax, fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add a couple of casts. BUG=614150 Committed: https://crrev.com/40c05d919958da304af825c140ee76a8e386c94b Cr-Commit-Position: refs/heads/master@{#395443}

Patch Set 1 #

Patch Set 2 : add another cast. #

Total comments: 1

Patch Set 3 : address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M components/offline_pages/offline_page_metadata_store_sql.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/offline_pages/offline_page_model.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/offline_pages/offline_page_storage_manager.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
bburns
4 years, 7 months ago (2016-05-23 20:33:51 UTC) #2
romax
lgtm
4 years, 7 months ago (2016-05-23 20:39:43 UTC) #3
fgorski
lgtm, but address the comment https://codereview.chromium.org/2004993002/diff/20001/components/offline_pages/offline_page_storage_manager.cc File components/offline_pages/offline_page_storage_manager.cc (right): https://codereview.chromium.org/2004993002/diff/20001/components/offline_pages/offline_page_storage_manager.cc#newcode115 components/offline_pages/offline_page_storage_manager.cc:115: int page_list_size = page_list.size(); ...
4 years, 7 months ago (2016-05-23 20:45:42 UTC) #4
fgorski
lgtm
4 years, 7 months ago (2016-05-23 20:50:06 UTC) #5
fgorski
please update description to BUG=614150
4 years, 7 months ago (2016-05-23 20:51:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004993002/40001
4 years, 7 months ago (2016-05-23 20:51:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/141902) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-05-23 20:56:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004993002/40001
4 years, 7 months ago (2016-05-23 22:42:49 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-23 22:47:55 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 22:49:40 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/40c05d919958da304af825c140ee76a8e386c94b
Cr-Commit-Position: refs/heads/master@{#395443}

Powered by Google App Engine
This is Rietveld 408576698