third_party/WebKit/LayoutTests/media/audio-controls-captions.html - Issue 2004963003: Convert audio-controls* and audio-delete* tests to testharness.js

Side by Side Diff: third_party/WebKit/LayoutTests/media/audio-controls-captions.html

Issue 2004963003: Convert audio-controls* and audio-delete* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <title>Tests that the closed captions button is not visible.</title>

3 <head>	3 <script src="media-file.js"></script>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <script src="media-controls.js"></script>

5 <title>Test closed caption button visbility.</title>	5 <script src="../resources/testharness.js"></script>

6 <script src=media-file.js></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src=media-controls.js></script>	7 <audio controls>

8 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	8 <track src="track/captions-webvtt/captions-fast.vtt">

9 (Please avoid writing new tests using video-test.js) -->	9 </audio>

10 <script src=video-test.js></script>	10 <script>

11 </head>	11 // TODO(srirama.m): This is a dummy function to avoid undefined error for

12 <body>	12 // consoleWrite() which is referenced from testClosedCaptionsButtonVisibility.

13 <p>Tests that the closed captions button is not visible.</p>	13 // This should be removed when video-test.js is knocked off finally.

14 <audio controls>	14 function consoleWrite(text) {

15 <track src="track/captions-webvtt/captions-fast.vtt">	15 }

16 </audio>	16

17 <script>	17 async_test(function(t) {

18 findMediaElement();	18 var audio = document.querySelector('audio');

19 audio.src = findMediaFile('audio', 'content/test');	19 audio.src = findMediaFile('audio', 'content/test');

20 audio.addEventListener('loadedmetadata', function()	20 audio.onloadedmetadata = t.step_func_done(testClosedCaptionsButtonVisibility (false));
	fs 2016/05/24 13:32:23 This doesn't look right, the argument ought to be This doesn't look right, the argument ought to be as before, or maybe using bind. Srirama 2016/05/24 13:41:28 you mean it should be ..... = t.step_func_done(fun Show quoted text On 2016/05/24 13:32:23, fs wrote: > This doesn't look right, the argument ought to be as before, or maybe using > bind. you mean it should be ..... = t.step_func_done(function() { testClosedCaptionsButtonVisibility(false)); }); ? Even directly calling a function inside it, is working fine. I just changed "false" to "true" and it fails the test. Will there be a problem with this? fs 2016/05/24 14:06:19 It's confusing as to what ordering is required. I Show quoted text On 2016/05/24 at 13:41:28, Srirama wrote: > On 2016/05/24 13:32:23, fs wrote: > > This doesn't look right, the argument ought to be as before, or maybe using > > bind. > > you mean it should be > ..... = t.step_func_done(function() { > testClosedCaptionsButtonVisibility(false)); > }); > ? > > Even directly calling a function inside it, is working fine. I just changed "false" to "true" and it fails the test. Will there be a problem with this? It's confusing as to what ordering is required. I think the intention of the test is to check that the 'CC' button isn't visible after the media file is sufficiently loaded. With the changes to track selection I think this passes trivially though.. (i.e the <track> should have a 'default' attribute added to be more reasonable.) testClosedCaptionsButtonVisibility appears to be using testExpected though too, how is that handled?
21 {	21 });

22 testClosedCaptionsButtonVisibility(false);	22 </script>

23 endTest();

24 });

25 </script>

26 </body>

27 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/audio-controls-captions-expected.txt » ('j') | no next file with comments »