Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2004933003: [builtins] Remove a few dead imports of InternalArray/InternalPackedArray. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Remove a few dead imports of InternalArray/InternalPackedArray. R=yangguo@chromium.org Committed: https://crrev.com/8153f4cd179ef3f202f0b6dcafa0928e1f419275 Cr-Commit-Position: refs/heads/master@{#36457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/js/math.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/string.js View 1 chunk +0 lines, -2 lines 0 comments Download
M src/js/v8natives.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-24 04:44:59 UTC) #1
Benedikt Meurer
Hey Yang, Dead code cleanup. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-24 04:45:29 UTC) #2
Yang
lgtm
4 years, 7 months ago (2016-05-24 05:02:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004933003/1
4 years, 7 months ago (2016-05-24 05:04:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 05:20:35 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 05:22:39 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8153f4cd179ef3f202f0b6dcafa0928e1f419275
Cr-Commit-Position: refs/heads/master@{#36457}

Powered by Google App Engine
This is Rietveld 408576698