Issue 2004933002: Simplify the canonicalization of dart-ext uris.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2004933002: Simplify the canonicalization of dart-ext uris. (Closed)

Created:
4 years, 7 months ago by turnidge

Modified:
4 years, 7 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Bill Hesse

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Simplify the canonicalization of dart-ext uris. We used to stuff the path of the canonicalizing library into the uri so that we could retrieve it later. That isn't necessary, as the library is still available when we import later. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b3a1066c8e5b202d9c0412236a12760956fa929d

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -63 lines)			Patch
M	runtime/bin/builtin.dart	View		3 chunks	+7 lines, -40 lines	0 comments	Download
M	runtime/bin/dartutils.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	1	3 chunks	+24 lines, -21 lines	0 comments	Download

Total messages: 6 (2 generated)

turnidge

4 years, 7 months ago (2016-05-23 17:23:12 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b3a1066c8e5b202d9c0412236a12760956fa929d (presubmit successful).