Support multiple resolution inputs from command line.

Support multiple resolution inputs from command line.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/42435f2643b178c2fd7b9d835a36f6fdaf4ed92c

[Johnni Winther, 2016-05-24 09:37:34]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2016-05-24 14:31:07]

Uploaded a revised patch.

[Siggi Cherem (dart-lang), 2016-05-24 18:08:15]

lgtm, nice to see this come together!

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/da...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart2js.dart:841: final Uri _SERIALIZED_URI =
Uri.parse('file:fake.data');
+dartdoc just to remember that this URI is a mock URI only used for our testing
for the time being.

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:3015: return cls.rawType;
I'm surprised to see this change here. How is this related to the multi-file
input?

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/se...
File pkg/compiler/lib/src/serialization/serialization.dart (right):

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/se...
pkg/compiler/lib/src/serialization/serialization.dart:757: if
(element.isAccessor) {
are the changes about Key.GETTER needed for supporting the multiple input files?
or is this unrelated? If so, can we split those changes in a separate CL (seems
like most changes above this line and a few further down)?

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/se...
pkg/compiler/lib/src/serialization/serialization.dart:938: {'libraryUri': uri,
'sourceUri1': foundUri, 'sourceUri2': deserializer.sourceUri});
dartfmt

https://codereview.chromium.org/2004833003/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/serialization/helper.dart (right):

https://codereview.chromium.org/2004833003/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization/helper.dart:131: void
expandMemorySourceFiles(Map<String, String> sourceFiles) {
are these expand methods used anywhere else? if not, consider inlining them.

[Johnni Winther, 2016-05-25 07:54:47]

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/da...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart2js.dart:841: final Uri _SERIALIZED_URI =
Uri.parse('file:fake.data');
On 2016/05/24 18:08:14, Siggi Cherem (dart-lang) wrote:
> +dartdoc just to remember that this URI is a mock URI only used for our
testing
> for the time being.

Done.

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:3015: return cls.rawType;
On 2016/05/24 18:08:15, Siggi Cherem (dart-lang) wrote:
> I'm surprised to see this change here. How is this related to the multi-file
> input?

It was a latent bug. When a JS call had for instance 'JSArray' in its
spec-string, like `JS('JSArray', '[]')`, we would store the type ? +
`JSArray<E>` in the native behavior instead of `JSArray<dynamic>`.

This came up when trying to serialize 'dart:_js_helper' in another file than the
one with the JS call, since we would try to reference an external type variable
which should be possible, allowed nor supported.

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/se...
File pkg/compiler/lib/src/serialization/serialization.dart (right):

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/se...
pkg/compiler/lib/src/serialization/serialization.dart:757: if
(element.isAccessor) {
On 2016/05/24 18:08:15, Siggi Cherem (dart-lang) wrote:
> are the changes about Key.GETTER needed for supporting the multiple input
files?
> or is this unrelated? If so, can we split those changes in a separate CL
(seems
> like most changes above this line and a few further down)?

These are needed. It turned out that because of the missing `shouldInclude`
argument to [Serializer] in library_test.dart we always had an internal version
of the referenced getters and setters.

With the correct split (and enforced disjointness) we now (for the first time)
need external references to getters and setters. Since we lookup by name only
(in the [find] and [lookupLocalMember] methods) we need to the extra bit to
access the right child of the [AbstractFieldElement].

https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/se...
pkg/compiler/lib/src/serialization/serialization.dart:938: {'libraryUri': uri,
'sourceUri1': foundUri, 'sourceUri2': deserializer.sourceUri});
On 2016/05/24 18:08:15, Siggi Cherem (dart-lang) wrote:
> dartfmt

Done.

https://codereview.chromium.org/2004833003/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/serialization/helper.dart (right):

https://codereview.chromium.org/2004833003/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization/helper.dart:131: void
expandMemorySourceFiles(Map<String, String> sourceFiles) {
On 2016/05/24 18:08:15, Siggi Cherem (dart-lang) wrote:
> are these expand methods used anywhere else? if not, consider inlining them.

They are used in library_test.

[Johnni Winther, 2016-05-25 09:02:48]

Description was changed from

==========
Support multiple resolution inputs from command line.

BUG=
==========

to

==========
Support multiple resolution inputs from command line.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/42435f2643b178c2fd7b9d835a36f6fdaf4ed92c
==========

[Johnni Winther, 2016-05-25 09:02:50]

Committed patchset #4 (id:60001) manually as
42435f2643b178c2fd7b9d835a36f6fdaf4ed92c (presubmit successful).

[sra1, 2016-05-27 20:47:22]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2016-05-27 20:47:23]

Please investigate why this CL adds 6% (77k) to the generated code size
benchmark CompileAngular2-tree

[Johnni Winther, 2016-05-30 08:58:17]

On 2016/05/27 20:47:23, sra1 wrote:
> Please investigate why this CL adds 6% (77k) to the generated code size
> benchmark CompileAngular2-tree

Hopefully fixed by https://codereview.chromium.org/2021723003/

[sra1, 2016-05-31 20:48:35]

On 2016/05/30 08:58:17, Johnni Winther wrote:
> On 2016/05/27 20:47:23, sra1 wrote:
> > Please investigate why this CL adds 6% (77k) to the generated code size
> > benchmark CompileAngular2-tree
> 
> Hopefully fixed by https://codereview.chromium.org/2021723003/

Thanks!