Issue 2004823002: Fix typed_data_iterable_test to not assume 0 can be added to toList result.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2004823002: Fix typed_data_iterable_test to not assume 0 can be added to toList result. (Closed)

Created:
4 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
4 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix typed_data_iterable_test to not assume 0 can be added to toList result. That's not true for float-lists. Committed: https://github.com/dart-lang/sdk/commit/0554fedc2e8ee0ec1527cbc9ec6c0367c639b000

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	tests/lib/typed_data/typed_list_iterable_test.dart	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

Lasse Reichstein Nielsen

Committed patchset #1 (id:1) manually as 0554fedc2e8ee0ec1527cbc9ec6c0367c639b000 (presubmit successful).

4 years, 7 months ago (2016-05-23 09:18:58 UTC) #4

Message was sent while issue was closed.

LGTM.