Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2004813003: Fix a generated header build flake in //media/base/android (Closed)

Created:
4 years, 7 months ago by tsniatowski
Modified:
4 years, 7 months ago
Reviewers:
qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a generated header build flake in //media/base/android BUG= Committed: https://crrev.com/22f0aa63015be0687bcf30031ec4257088cceff7 Cr-Commit-Position: refs/heads/master@{#395421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/base/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tsniatowski
On 2016/05/23 09:52:15, tsniatowski wrote: > mailto:tsniatowski@opera.com changed reviewers: > + mailto:qinmin@chromium.org PTAL
4 years, 7 months ago (2016-05-23 09:52:41 UTC) #3
tsniatowski
4 years, 7 months ago (2016-05-23 09:52:48 UTC) #4
qinmin
lgtm
4 years, 7 months ago (2016-05-23 19:09:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004813003/1
4 years, 7 months ago (2016-05-23 19:12:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 21:42:58 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 21:45:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22f0aa63015be0687bcf30031ec4257088cceff7
Cr-Commit-Position: refs/heads/master@{#395421}

Powered by Google App Engine
This is Rietveld 408576698