Fix for FastUri.hashCode and hasAuthorizy (to fix ==).

Fix for FastUri.hashCode and hasAuthorizy (to fix ==).

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5f7f716b9362bd01e44a5705ebd516f67b78f383

[Brian Wilkerson, 2016-05-23 13:53:53]

lgtm

https://codereview.chromium.org/2004793002/diff/1/pkg/analyzer/lib/src/util/f...
File pkg/analyzer/lib/src/util/fast_uri.dart (right):

https://codereview.chromium.org/2004793002/diff/1/pkg/analyzer/lib/src/util/f...
pkg/analyzer/lib/src/util/fast_uri.dart:280: if (!path.startsWith('/')) {
If the path starts with two slashes, how can it not start with a slash?

[scheglov, 2016-05-23 13:58:10]

https://codereview.chromium.org/2004793002/diff/1/pkg/analyzer/lib/src/util/f...
File pkg/analyzer/lib/src/util/fast_uri.dart (right):

https://codereview.chromium.org/2004793002/diff/1/pkg/analyzer/lib/src/util/f...
pkg/analyzer/lib/src/util/fast_uri.dart:280: if (!path.startsWith('/')) {
On 2016/05/23 13:53:53, Brian Wilkerson wrote:
> If the path starts with two slashes, how can it not start with a slash?

Ouch...
This code should be after updating the path.
Fixed.
Thank you.

[Paul Berry, 2016-05-23 15:34:01]

lgtm

https://codereview.chromium.org/2004793002/diff/20001/pkg/analyzer/lib/src/ut...
File pkg/analyzer/lib/src/util/fast_uri.dart (right):

https://codereview.chromium.org/2004793002/diff/20001/pkg/analyzer/lib/src/ut...
pkg/analyzer/lib/src/util/fast_uri.dart:66: // This code is copied from the
standard Uri implementation.
Nit: Consider including a comment explaining why it's necessary to copy this
code from the standard Uri implementation, e.g.

"It is important that Uri and FastUri generate compatible hashCodes because Uri
and FastUri may be used as keys in the same map."

[scheglov, 2016-05-23 15:44:14]

Description was changed from

==========
Fix for FastUri.hashCode and hasAuthorizy (to fix ==).

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Fix for FastUri.hashCode and hasAuthorizy (to fix ==).

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/5f7f716b9362bd01e44a5705ebd516f67b78f383
==========

[scheglov, 2016-05-23 15:44:16]

Committed patchset #2 (id:20001) manually as
5f7f716b9362bd01e44a5705ebd516f67b78f383 (presubmit successful).