Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2004743002: [iOS/GN] Fix the compilation of "all" on iOS with gn. (Closed)

Created:
4 years, 7 months ago by sdefresne
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, wfh+watch_chromium.org, tdresser+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, huangs+watch_chromium.org, blink-reviews, darin (slow to review), ben+mojo_chromium.org, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/GN] Fix the compilation of "all" on iOS with gn. Move definition of executables that cannot be run on iOS, sources that do not build, test suite that are empty and unsupported deps behind !is_ios checks. Add "assert(!is_ios)" in some WebKit BUILD.gn as it cannot be used on iOS (need to use the version shipped with the system). This fix running ninja without specifying any target (i.e. building "all"). BUG=603127, 459705 Committed: https://crrev.com/6fd373e52da6598c696918f1100ad81074b14740 Cr-Commit-Position: refs/heads/master@{#395699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -242 lines) Patch
M courgette/BUILD.gn View 1 chunk +30 lines, -28 lines 0 comments Download
M ipc/BUILD.gn View 1 chunk +93 lines, -91 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 4 chunks +23 lines, -16 lines 0 comments Download
M mojo/edk/test/BUILD.gn View 2 chunks +7 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 1 chunk +16 lines, -14 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 2 chunks +26 lines, -21 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +9 lines, -4 lines 0 comments Download
M services/shell/public/cpp/BUILD.gn View 1 chunk +33 lines, -31 lines 0 comments Download
M services/shell/standalone/BUILD.gn View 2 chunks +7 lines, -2 lines 0 comments Download
M skia/BUILD.gn View 1 chunk +23 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/boringssl/BUILD.gn View 1 chunk +13 lines, -11 lines 0 comments Download
M ui/events/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
sdefresne
Please take a look.
4 years, 7 months ago (2016-05-21 13:29:37 UTC) #2
Dirk Pranke
lgtm. Note, though, that you're making "all" work, not "All", right? "All" builds the same ...
4 years, 7 months ago (2016-05-23 20:36:19 UTC) #4
brettw
lgtm
4 years, 7 months ago (2016-05-23 20:51:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004743002/1
4 years, 7 months ago (2016-05-24 06:45:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/226930)
4 years, 7 months ago (2016-05-24 12:24:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004743002/1
4 years, 7 months ago (2016-05-24 15:47:23 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 21:24:21 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 21:26:56 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fd373e52da6598c696918f1100ad81074b14740
Cr-Commit-Position: refs/heads/master@{#395699}

Powered by Google App Engine
This is Rietveld 408576698