Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2004733002: [builtins] Migrate String.fromCharCode to C++. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate String.fromCharCode to C++. The previous JavaScript version created way too many ConsStrings for longer strings, i.e. when using String.fromCharCode together with Function.prototype.apply and arrays of char codes. This version now always allocates sequential strings and therefore uses way less memory when turning longer character sequences into strings, and therefore fixes the memory regression on Google Maps. BUG=chromium:609831 R=yangguo@chromium.org Committed: https://crrev.com/cc71837fdae85a2b92db65d29146b2ab89ba77da Cr-Commit-Position: refs/heads/master@{#36427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -52 lines) Patch
M src/bootstrapper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M src/js/string.js View 2 chunks +0 lines, -13 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +22 lines, -0 lines 0 comments Download
D test/mjsunit/regress/regress-seqstrsetchar-ex2.js View 1 chunk +0 lines, -34 lines 0 comments Download
M test/mjsunit/string-fromcharcode.js View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-21 09:37:47 UTC) #1
Benedikt Meurer
Hey Yang, Here's the fix for String.fromCharCode regression on Google Maps. Please take a look. ...
4 years, 7 months ago (2016-05-21 09:38:34 UTC) #2
Yang
lgtm. We still have the inlined fast path for the one argument case (at least ...
4 years, 7 months ago (2016-05-21 11:45:49 UTC) #3
Benedikt Meurer
Yes, that's untouched. I also want to do a fast inline path for TurboFan, but ...
4 years, 7 months ago (2016-05-21 16:52:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004733002/1
4 years, 7 months ago (2016-05-21 16:56:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-21 16:58:28 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 17:00:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc71837fdae85a2b92db65d29146b2ab89ba77da
Cr-Commit-Position: refs/heads/master@{#36427}

Powered by Google App Engine
This is Rietveld 408576698