Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 200473005: Use ElementTraversal API in siblingWithAriaRole() to simplify the code (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
dmazzoni, adamk
CC:
blink-reviews, dmazzoni, aboxhall
Visibility:
Public.

Description

Use ElementTraversal API in siblingWithAriaRole() to simplify the code Use ElementTraversal API in siblingWithAriaRole() to simplify the code a bit. R=adamk, dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
6 years, 9 months ago (2014-03-14 19:56:13 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-14 20:40:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/200473005/1
6 years, 9 months ago (2014-03-14 20:40:23 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 20:40:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-14 20:40:40 UTC) #5
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-14 20:42:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/200473005/1
6 years, 9 months ago (2014-03-14 20:42:21 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 21:31:05 UTC) #8
Message was sent while issue was closed.
Change committed as 169280

Powered by Google App Engine
This is Rietveld 408576698