chrome/common/chrome_paths_unittest.cc - Issue 200473002: Move all callers of GetHomeDir() to PathService::Get(base::DIR_HOME).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_paths_unittest.cc

Issue 200473002: Move all callers of GetHomeDir() to PathService::Get(base::DIR_HOME). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/chrome_paths_unittest.cc

diff --git a/chrome/common/chrome_paths_unittest.cc b/chrome/common/chrome_paths_unittest.cc

index 525115473a5464133de527047c8c1bfed20d3523..3816cf64e5d73b777af29358ff52d664016ac23d 100644

--- a/chrome/common/chrome_paths_unittest.cc

+++ b/chrome/common/chrome_paths_unittest.cc

@@ -6,6 +6,7 @@

#include <stdlib.h>

+#include "base/base_paths.h"

#include "base/file_util.h"

#include "base/files/file_path.h"

#include "base/path_service.h"

@@ -29,7 +30,8 @@ TEST(ChromePaths, UserCacheDir) {

base::FilePath expected_cache_dir;

ASSERT_TRUE(PathService::Get(base::DIR_CACHE, &expected_cache_dir));

#elif(OS_POSIX)

- base::FilePath homedir = base::GetHomeDir();

+ base::FilePath homedir;

+ PathService::Get(base::DIR_HOME, &homedir);

// Note: we assume XDG_CACHE_HOME/XDG_CONFIG_HOME are at their

// default settings.

test_profile_dir = homedir.Append(".config/foobar");