Move all callers of GetHomeDir() to PathService::Get(base::DIR_HOME).

content/browser/ppapi_plugin_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/ppapi_plugin_process_host.h"
 
 #include <string>
 
+#include "base/base_paths.h"
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/metrics/field_trial.h"
+#include "base/path_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/browser_child_process_host_impl.h"
 #include "content/browser/plugin_service_impl.h"
 #include "content/browser/renderer_host/render_message_filter.h"
 #include "content/common/child_process_host_impl.h"
 #include "content/common/child_process_messages.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/pepper_plugin_info.h"
@@ skipping 276 matching lines @@
     VLOG(1) << "Pepper plugin exe path is empty.";
     return false;
   }
 
   CommandLine* cmd_line = new CommandLine(exe_path);
   cmd_line->AppendSwitchASCII(switches::kProcessType,
                               is_broker_ ? switches::kPpapiBrokerProcess
                                          : switches::kPpapiPluginProcess);
   cmd_line->AppendSwitchASCII(switches::kProcessChannelID, channel_id);
 
+#if defined(OS_CHROMEOS)
+  // On Chrome OS need to pass primary user homedir.

[Will Drewry, 2014/04/08 15:55:04]

What does PPAPI use the home dir for?  What sort of side effects can it have on
the primary user data?

[Nikita (slow), 2014/04/08 16:40:08]

This doesn't change how it is implemented right now since now it is using
GetHomeDir() which returns /home/chronos/user which is the primary user home
dir.

I don't know what they used it for, here's the snippet
https://code.google.com/p/chromium/codesearch#chromium/src/content/ppapi_plug...

// Specifies $HOME explicitly because some plugins rely on $HOME but
// no other part of Chrome OS uses that.  See crbug.com/335290.

https://code.google.com/p/chromium/issues/detail?id=335290 mentions
ScreenshotTaker.

+  base::FilePath homedir;
+  PathService::Get(base::DIR_HOME, &homedir);
+  cmd_line->AppendSwitchASCII(switches::kHomedir, homedir.value().c_str());
+#endif
+
   // These switches are forwarded to both plugin and broker pocesses.
   static const char* kCommonForwardSwitches[] = {
     switches::kVModule
   };
   cmd_line->CopySwitchesFrom(browser_command_line, kCommonForwardSwitches,
                              arraysize(kCommonForwardSwitches));
 
   if (!is_broker_) {
     static const char* kPluginForwardSwitches[] = {
       switches::kDisableSeccompFilterSandbox,
@@ skipping 139 matching lines @@
   // sent_requests_ queue should be the one that the plugin just created.
   Client* client = sent_requests_.front();
   sent_requests_.pop();
 
   const ChildProcessData& data = process_->GetData();
   client->OnPpapiChannelOpened(channel_handle, base::GetProcId(data.handle),
                                data.id);
 }
 
 }  // namespace content