Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2004723002: Handle ReadyStateEnded in MediaRecorderHandler (Closed)

Created:
4 years, 7 months ago by emircan
Modified:
4 years, 7 months ago
Reviewers:
mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle ReadyStateEnded in MediaRecorderHandler This CL addresses the fuzz discovered issue below. We receive two tracks that are ReadyStateEnded and currently, it isn't handled properly. BUG=612958 Committed: https://crrev.com/fc3c6cf87f1d61d9bad732183463723841d1be1e Cr-Commit-Position: refs/heads/master@{#395379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/renderer/media/media_recorder_handler.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
emircan
PTAL. Let me know if you need another way to fix this.
4 years, 7 months ago (2016-05-21 07:18:49 UTC) #3
mcasas
LGTM makes sense seeing [1] [1] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp&sq=package:chromium&type=cs&l=185&rcl=1463987841
4 years, 7 months ago (2016-05-23 14:43:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004723002/1
4 years, 7 months ago (2016-05-23 18:00:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 19:00:48 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 19:01:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc3c6cf87f1d61d9bad732183463723841d1be1e
Cr-Commit-Position: refs/heads/master@{#395379}

Powered by Google App Engine
This is Rietveld 408576698