Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: remoting/webapp/base/js/client_session.js

Issue 2004673002: Initialize remoting.ClientSession.PerfStats with zeros (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer's Feedback & Mark Fields Non-nullable Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/base/js/client_session.js
diff --git a/remoting/webapp/base/js/client_session.js b/remoting/webapp/base/js/client_session.js
index eda42d7891f85299f911988dd9d3cb5ee8bf005b..9c8b4756fd31bec7e5221b454c04ab09f16db6c1 100644
--- a/remoting/webapp/base/js/client_session.js
+++ b/remoting/webapp/base/js/client_session.js
@@ -202,30 +202,30 @@ remoting.ClientSession.ConnectionError.fromString = function(error) {
* @constructor
*/
remoting.ClientSession.PerfStats = function() {};
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.videoBandwidth;
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.videoFrameRate;
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.captureLatency;
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.maxCaptureLatency;
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.encodeLatency;
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.maxEncodeLatency;
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.decodeLatency;
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.maxDecodeLatency;
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.renderLatency;
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.maxRenderLatency;
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.roundtripLatency;
-/** @type {number} */
-remoting.ClientSession.PerfStats.prototype.maxRoundtripLatency;
+/** @type {!number} */
Jamie 2016/05/23 18:18:27 Number is not a nullable type, so you don't need t
Yuwei 2016/05/23 18:25:23 Done.
+remoting.ClientSession.PerfStats.prototype.videoBandwidth = 0;
+/** @type {!number} */
+remoting.ClientSession.PerfStats.prototype.videoFrameRate = 0;
+/** @type {!number} */
+remoting.ClientSession.PerfStats.prototype.captureLatency = 0;
+/** @type {!number} */
+remoting.ClientSession.PerfStats.prototype.maxCaptureLatency = 0;
+/** @type {!number} */
+remoting.ClientSession.PerfStats.prototype.encodeLatency = 0;
+/** @type {!number} */
+remoting.ClientSession.PerfStats.prototype.maxEncodeLatency = 0;
+/** @type {!number} */
+remoting.ClientSession.PerfStats.prototype.decodeLatency = 0;
+/** @type {!number} */
+remoting.ClientSession.PerfStats.prototype.maxDecodeLatency = 0;
+/** @type {!number} */
+remoting.ClientSession.PerfStats.prototype.renderLatency = 0;
+/** @type {!number} */
+remoting.ClientSession.PerfStats.prototype.maxRenderLatency = 0;
+/** @type {!number} */
+remoting.ClientSession.PerfStats.prototype.roundtripLatency = 0;
+/** @type {!number} */
+remoting.ClientSession.PerfStats.prototype.maxRoundtripLatency = 0;
// Keys for connection statistics.
remoting.ClientSession.STATS_KEY_VIDEO_BANDWIDTH = 'videoBandwidth';
« no previous file with comments | « no previous file | remoting/webapp/base/js/connection_stats.js » ('j') | remoting/webapp/base/js/stats_accumulator.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698