Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2004663002: [MD settings] change line heights and section widths (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] change line heights and section widths This CL makes several css adjustments that Alan requested. The changes are specified in the bugs mentioned below (not yet in the mocks). BUG=613734, 613730, 614098, 614100 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ad23d7ac868e5f7630bfb31013bed9c0a0aebbb4 Cr-Commit-Position: refs/heads/master@{#395386}

Patch Set 1 : background color #

Total comments: 4

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_page.css View 1 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
dschuyler
This is that demo you saw with Alan.
4 years, 7 months ago (2016-05-20 23:27:48 UTC) #4
tommycli
https://codereview.chromium.org/2004663002/diff/20001/chrome/browser/resources/settings/settings_page.css File chrome/browser/resources/settings/settings_page.css (right): https://codereview.chromium.org/2004663002/diff/20001/chrome/browser/resources/settings/settings_page.css#newcode17 chrome/browser/resources/settings/settings_page.css:17: :host > * { Add a comment as to ...
4 years, 7 months ago (2016-05-20 23:40:39 UTC) #5
dschuyler
https://codereview.chromium.org/2004663002/diff/20001/chrome/browser/resources/settings/settings_page.css File chrome/browser/resources/settings/settings_page.css (right): https://codereview.chromium.org/2004663002/diff/20001/chrome/browser/resources/settings/settings_page.css#newcode17 chrome/browser/resources/settings/settings_page.css:17: :host > * { On 2016/05/20 23:40:39, tommycli wrote: ...
4 years, 7 months ago (2016-05-20 23:46:57 UTC) #6
tommycli
lgtm thanks for the comments!
4 years, 7 months ago (2016-05-20 23:50:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004663002/40001
4 years, 7 months ago (2016-05-23 18:06:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-23 19:34:17 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 19:36:29 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad23d7ac868e5f7630bfb31013bed9c0a0aebbb4
Cr-Commit-Position: refs/heads/master@{#395386}

Powered by Google App Engine
This is Rietveld 408576698