OpenURL post data handling.

content/browser/frame_host/navigator_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigator_impl.h"
 
 #include <utility>
 
 #include "base/metrics/histogram.h"
 #include "base/time/time.h"
@@ skipping 626 matching lines @@
   // about:blank should not "use up" a new SiteInstance.  The SiteInstance can
   // still be used for a normal web site.
   if (url == GURL(url::kAboutBlankURL))
     return false;
 
   // The embedder will then have the opportunity to determine if the URL
   // should "use up" the SiteInstance.
   return GetContentClient()->browser()->ShouldAssignSiteForURL(url);
 }
 
-void NavigatorImpl::RequestOpenURL(RenderFrameHostImpl* render_frame_host,
-                                   const GURL& url,
-                                   SiteInstance* source_site_instance,
-                                   const Referrer& referrer,
-                                   WindowOpenDisposition disposition,
-                                   bool should_replace_current_entry,
-                                   bool user_gesture) {
+void NavigatorImpl::RequestOpenURL(
+    RenderFrameHostImpl* render_frame_host,
+    const GURL& url,
+    const std::string& method,
+    const scoped_refptr<ResourceRequestBody>& body,
+    SiteInstance* source_site_instance,
+    const Referrer& referrer,
+    WindowOpenDisposition disposition,
+    bool should_replace_current_entry,
+    bool user_gesture) {
   // Note: This can be called for subframes (even when OOPIFs are not possible)
   // if the disposition calls for a different window.
 
   // Only the current RenderFrameHost should be sending an OpenURL request.
   // Pending RenderFrameHost should know where it is navigating and pending
   // deletion RenderFrameHost shouldn't be trying to navigate.
   if (render_frame_host !=
       render_frame_host->frame_tree_node()->current_frame_host()) {
     return;
   }
@@ skipping 42 matching lines @@
     // Note also that we hide the referrer for Web UI pages. We don't really
     // want web sites to see a referrer of "chrome://blah" (and some
     // chrome: URLs might have search terms or other stuff we don't want to
     // send to the site), so we send no referrer.
     params.referrer = Referrer();
 
     // Navigations in Web UI pages count as browser-initiated navigations.
     params.is_renderer_initiated = false;
   }
 
+  // TODO / DO NOT SUBMIT: Need to plumb through |method| and |body|.
+  //
+  // Option #1:
+  // - Add |method| and |body| fields to OpenURLParams
+  //   - OpenURLParams is //content's public API
+  //   - ResourceRequestBody (the type of |body| variable here) is currently
+  //     internal to //content, but maybe we can expose a small part of it via
+  //     //content's public API:
+  //     - expose: ResourceRequestBody::CreateFromVectorOfBytes
+  //     - expose: thread-safe-ref-counting of ResourceRequestBody
+  //     - hide: ResourceRequestBody::impl_ (unique pointer to RRBImpl)
+  //
+  // Option #2:
+  // - |delegate_| below is still an internal-to-//content NavigatorDelegate.
+  //   So maybe we can keep things internal somehow?  I don't see how, since
+  //   ultimately we will always call into //chrome (or other embedder
+  //   of //content).

[Łukasz Anforowicz, 2016/05/20 23:24:22]

WDYT?  Does option #1 (exposing a minimal ResourceRequestBody out of //content's
public API) make sense?  I am not sure what is Chromium's stance toward classes
that only have an "impl" pointer.

Is there some other option here that I am missing?

[Łukasz Anforowicz, 2016/05/23 13:43:18]

Actually, feel free to ignore the question - after sleeping on the problem, I
now see that I should just do this in a similar way to what //content already
does for RFH/RFHI:

//content/public/common/resource_request_body.h (new file):

class CONTENT_EXPORT ResourceRequestBody
    : public base::RefCountedThreadSafe<ResourceRequestBody> {
 public:
  scoped_refptr<ResourceRequestBody> CreateFromBytes(
      const std::vector<char> bytes);

  // no public API, except CreateFromBytes + ref-counting.

 protected:
  ResourceRequestBody();

 private:
  friend class base::RefCountedThreadSafe<ResourceRequestBody>;
  DISALLOW_COPY_AND_ASSIGN(ResourceRequestBody);  
} 

//content/common/resource_request_body_impl.h (renamed from the old
//content/common/resource_request_body.h):
 
class CONTENT_EXPORT ResourceRequestBodyImpl
    : public ResourceRequestBody,
      public base::SupportsUserData {
 // All the old declarations and members...
}

   if (delegate_)
     delegate_->RequestOpenURL(render_frame_host, params);
 }
 
 void NavigatorImpl::RequestTransferURL(
     RenderFrameHostImpl* render_frame_host,
     const GURL& url,
     SiteInstance* source_site_instance,
     const std::vector<GURL>& redirect_chain,
     const Referrer& referrer,
@@ skipping 437 matching lines @@
   if (pending_entry != controller_->GetVisibleEntry() ||
       !should_preserve_entry) {
     controller_->DiscardPendingEntry(true);
 
     // Also force the UI to refresh.
     controller_->delegate()->NotifyNavigationStateChanged(INVALIDATE_TYPE_URL);
   }
 }
 
 }  // namespace content