content/browser/background_sync/background_sync_manager_unittest.cc - Issue 2004643002: Implement BroadcastChannel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager_unittest.cc

Issue 2004643002: Implement BroadcastChannel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: try to fix ios gyp build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/webmessaging/public/interfaces/broadcast_channel.mojom ('K') | « content/browser/DEPS ('k') | content/browser/background_sync/background_sync_service_impl_unittest.cc » ('j') | content/browser/storage_partition_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager_unittest.cc

diff --git a/content/browser/background_sync/background_sync_manager_unittest.cc b/content/browser/background_sync/background_sync_manager_unittest.cc

index f4acfb7f31d763f2a72a828c1b075314b63acb89..cfe3f78266c5a5c937554f045732bb1d315ec0cb 100644

--- a/content/browser/background_sync/background_sync_manager_unittest.cc

+++ b/content/browser/background_sync/background_sync_manager_unittest.cc

@@ -138,7 +138,7 @@ class BackgroundSyncManagerTest : public testing::Test {

storage_partition_impl_.reset(new StoragePartitionImpl(

helper_->browser_context(), base::FilePath(), nullptr, nullptr, nullptr,

nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,

- nullptr, nullptr));

+ nullptr, nullptr, nullptr));

dcheng 2016/06/30 08:23:12 Unrelated, but this could probably use benefit gre

Marijn Kruisselbrink 2016/06/30 17:21:56 Yeah, the way StoragePartitions are currently crea

helper_->context_wrapper()->set_storage_partition(

storage_partition_impl_.get());