Fix some style issues in sysdeps/nacl/irt_syscalls.*

Fix some style issues in sysdeps/nacl/irt_syscalls.*

- Untabify code
- Add line breaks for >80 lines
- Fix the type __nacl_irt_thread_create

BUG=https://code.google.com/p/chromium/issues/detail?id=352498
R=mseaborn@chromium.org

Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=21ee5d1

[hamaji, 2014-03-14 16:16:36]

Our project is tracking these files to share the implementation with glibc. It's
a bit annoying to deal with these tabs when we roll nacl-glibc.

[Mark Seaborn, 2014-03-14 17:21:29]

Can you use a full URL in the BUG= field, please, to disambiguate?

https://codereview.chromium.org/200463002/diff/1/sysdeps/nacl/irt_syscalls.c
File sysdeps/nacl/irt_syscalls.c (right):

https://codereview.chromium.org/200463002/diff/1/sysdeps/nacl/irt_syscalls.c#...
sysdeps/nacl/irt_syscalls.c:264: newfd);
Please fix indentation to line up.  Same for other cases below.

[hamaji, 2014-03-14 17:50:26]

Oops, fixed indentations. I also added linebreaks for appropriate places, and
fixed the type of __nacl_irt_thread_create (gcc outputs a warning for this)

[Mark Seaborn, 2014-03-14 17:56:45]

LGTM.  glibc style is to use tabs, but these files aren't likely to be
upstreamed, so untabifying is OK.

https://codereview.chromium.org/200463002/diff/20001/sysdeps/nacl/irt_syscalls.c
File sysdeps/nacl/irt_syscalls.c (right):

https://codereview.chromium.org/200463002/diff/20001/sysdeps/nacl/irt_syscall...
sysdeps/nacl/irt_syscalls.c:639: {
This should be indented deeper

[hamaji, 2014-03-14 18:31:37]

https://codereview.chromium.org/200463002/diff/20001/sysdeps/nacl/irt_syscalls.c
File sysdeps/nacl/irt_syscalls.c (right):

https://codereview.chromium.org/200463002/diff/20001/sysdeps/nacl/irt_syscall...
sysdeps/nacl/irt_syscalls.c:639: {
On 2014/03/14 17:56:45, Mark Seaborn wrote:
> This should be indented deeper

Done.

[hamaji, 2014-03-14 18:31:42]

The CQ bit was checked by hamaji@chromium.org

[Sergey Berezin, 2014-03-14 23:40:23]

On 2014/03/14 18:31:42, hamaji wrote:
> The CQ bit was checked by mailto:hamaji@chromium.org

CQ does not recognize this base URL, and therefore cannot process this CL.
Please consider committing manually.

[Sergey Berezin, 2014-03-14 23:40:26]

The CQ bit was unchecked by sergeyberezin@chromium.org

[hamaji, 2014-03-14 23:50:39]

I see. Mark or Sergey, could you land this for me? It seems I don't have a write
permission for this repository.

[hamaji, 2014-03-26 02:49:39]

Ping? I'm not rushed at all though.

[Roland McGrath, 2014-03-26 17:24:48]

I've added you to the ACL, so git cl push should work now.
After that you need to send a change for the main native_client repo's
tools/REVISIONS to get the toolchain builders to take the change (and once they
build, another change to TOOL_REVISIONS to deploy it).  But since this is a
cosmetic source change only, it doesn't matter so much if you follow through on
those steps.

[hamaji, 2014-03-27 05:18:12]

Hmm I couldn't get this change landed. I think I have tried three URLs

https://chromium.googlesource.com/native_client/nacl-glibc
http://chromium.googlesource.com/native_client/nacl-glibc.git  (as I have
noticed other people are using this base URL in rietveld)
http://git.chromium.org/native_client/nacl-glibc.git  (just in case...)

and I tried both @chromium.org and @google.com. I also have registered my ssh
public key to gerrit.chromium.org (I guessed this might not be relevant to
nacl-glibc repository though).

The first URL showed error message like

About to commit; enter to confirm.
fatal: remote error: Git access forbidden

and other two showed

About to commit; enter to confirm.
ssh: connect to host gerrit.chromium.org port 22: Connection refused
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I might be doing something stupid... Any idea?

[hamaji, 2014-04-09 22:49:27]

ping?

[hamaji, 2014-05-28 04:12:20]

Committed patchset #6 manually as r21ee5d1 (presubmit successful).