Home and End keys should not be processed by the autocomplete popup

Autocomplete popup should not handle the Home and end key messages, they should be left to the text edit to proceed.

BUG=4874
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9164

[Matt Perry, 2009-02-04 19:07:35]

http://codereview.chromium.org/20046/diff/11/1005
File webkit/glue/webview_impl.cc (right):

http://codereview.chromium.org/20046/diff/11/1005#newcode512
Line 512: event.key_code == VKEY_HOME || event.key_code == VKEY_END) {
Couldn't the popup itself just return false from isInterestedInEventForKey for
these event types?

[jcampan, 2009-02-04 19:14:46]

http://codereview.chromium.org/20046/diff/11/1005
File webkit/glue/webview_impl.cc (right):

http://codereview.chromium.org/20046/diff/11/1005#newcode512
Line 512: event.key_code == VKEY_HOME || event.key_code == VKEY_END) {
On 2009/02/04 19:07:36, Matt Perry wrote:
> Couldn't the popup itself just return false from isInterestedInEventForKey for
> these event types?
It could, but since for the drop-down case we want the keys to be processed by
the popup, it would be yet another setting on the popup on which keys it is
interested in.
Since all the logic of when to show/hide the popup is already in webview_impl, I
thought this would be simpler to have it done here.

[Matt Perry, 2009-02-04 19:49:47]

LGTM

http://codereview.chromium.org/20046/diff/11/1005
File webkit/glue/webview_impl.cc (right):

http://codereview.chromium.org/20046/diff/11/1005#newcode512
Line 512: event.key_code == VKEY_HOME || event.key_code == VKEY_END) {
On 2009/02/04 19:14:46, jcampan wrote:
> On 2009/02/04 19:07:36, Matt Perry wrote:
> > Couldn't the popup itself just return false from isInterestedInEventForKey
for
> > these event types?
> It could, but since for the drop-down case we want the keys to be processed by
> the popup, it would be yet another setting on the popup on which keys it is
> interested in.
> Since all the logic of when to show/hide the popup is already in webview_impl,
I
> thought this would be simpler to have it done here.
> 

Oh I see, this doesn't apply to select popups.  Fair enough.