Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2004533002: mash: Fix mash in debug builds. (Closed)

Created:
4 years, 7 months ago by Elliot Glaysher
Modified:
4 years, 7 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Fix mash in debug builds. X11EventSource::GetInstance() would DCHECK if it had no instance. Add a dedicated bool returning checker function and use it where we were crashing. BUG=594600 Committed: https://crrev.com/fd1cc4c7b4cb560f2fd7d23ac9f4ebf005f88e44 Cr-Commit-Position: refs/heads/master@{#395125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/chrome_browser_main_extra_parts_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/platform/x11/x11_event_source.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/platform/x11/x11_event_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Elliot Glaysher
4 years, 7 months ago (2016-05-20 18:10:46 UTC) #2
sadrul
thanks. lgtm
4 years, 7 months ago (2016-05-20 18:14:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004533002/1
4 years, 7 months ago (2016-05-20 18:15:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/187495)
4 years, 7 months ago (2016-05-20 18:23:13 UTC) #7
Elliot Glaysher
+sky for OWNERS stamp
4 years, 7 months ago (2016-05-20 18:25:32 UTC) #9
sky
LGTM
4 years, 7 months ago (2016-05-20 18:27:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004533002/1
4 years, 7 months ago (2016-05-20 18:31:38 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 18:58:22 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 18:59:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd1cc4c7b4cb560f2fd7d23ac9f4ebf005f88e44
Cr-Commit-Position: refs/heads/master@{#395125}

Powered by Google App Engine
This is Rietveld 408576698