Use DidOverscrollParams in the browser

Use DidOverscrollParams in the browser

Adopt usage of the DidOverscrollParams struct for overscroll notifications from
the renderer.  This eases the burden of changing overscroll metadata in the
future, and simplifies overscroll-related methods.

This also fixes an issue where repeated flings into the same edge would not
trigger the overscroll effect until a different edge overscrolled or the
overscroll was generated by a touch scroll.

BUG=354444
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266805

[jdduke (slow), 2014-04-24 20:38:46]

aelias@: Review for content/browser/android and content/browser/renderer_host. 
How's this for a 9 month old patch...

cevans@: Security review for content/common/view_messages.h
jam@: Owner review for content/port.

[aelias_OOO_until_Jul13, 2014-04-25 00:30:11]

lgtm

[jam, 2014-04-25 05:09:07]

lgtm with comment

https://codereview.chromium.org/20045007/diff/15001/content/port/browser/rend...
File content/port/browser/render_widget_host_view_port.h (right):

https://codereview.chromium.org/20045007/diff/15001/content/port/browser/rend...
content/port/browser/render_widget_host_view_port.h:312: virtual void
DidOverscroll(const DidOverscrollParams& params) = 0;
any struct used in content/port must be in content/port or content/public
(otherwise an embedder using this would have to reach into the internal
implementation of content). move this struct to content/port/common

[jdduke (slow), 2014-04-25 14:44:32]

https://codereview.chromium.org/20045007/diff/15001/content/port/browser/rend...
File content/port/browser/render_widget_host_view_port.h (right):

https://codereview.chromium.org/20045007/diff/15001/content/port/browser/rend...
content/port/browser/render_widget_host_view_port.h:312: virtual void
DidOverscroll(const DidOverscrollParams& params) = 0;
On 2014/04/25 05:09:07, jam wrote:
> any struct used in content/port must be in content/port or content/public
> (otherwise an embedder using this would have to reach into the internal
> implementation of content). move this struct to content/port/common

Hmm, I wonder if I should remove this method entirely.  It's only used on
Android, and will likely remain that way for the foreseeable future, so I'll
just handle the message in RWHVA without cluttering the view.  I'll amend the
patch.

[jdduke (slow), 2014-04-25 17:23:54]

jam@: I removed the overscroll wiring from port/, still look OK?

[jam, 2014-04-25 18:45:02]

On 2014/04/25 17:23:54, jdduke wrote:
> jam@: I removed the overscroll wiring from port/, still look OK?

looks even better, thanks
lgtm

[jdduke (slow), 2014-04-28 20:05:34]

palmer@: Security review for content/common/view_messages.h? Thanks.

[palmer, 2014-04-28 21:19:58]

IPC security LGTM

[jdduke (slow), 2014-04-28 21:34:50]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-28 21:35:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/20045007/75001

[commit-bot: I haz the power, 2014-04-28 21:35:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 21:35:39]

Failed to apply patch for
content/browser/renderer_host/render_widget_host_view_base.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/browser/renderer_host/render_widget_host_view_base.h
  Hunk #1 FAILED at 80.
  1 out of 1 hunk FAILED -- saving rejects to file
content/browser/renderer_host/render_widget_host_view_base.h.rej

Patch:       content/browser/renderer_host/render_widget_host_view_base.h
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h
b/content/browser/renderer_host/render_widget_host_view_base.h
index
284874ca51307b27ba94112dac18880e203cc56e..357c6711195a8499e7fefdbcf521e28336ef11b6
100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -80,8 +80,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase
       uint32 output_surface_id,
       scoped_ptr<cc::CompositorFrame> frame) OVERRIDE {}
   virtual void ResizeCompositingSurface(const gfx::Size&) OVERRIDE {}
-  virtual void OnOverscrolled(gfx::Vector2dF accumulated_overscroll,
-                              gfx::Vector2dF current_fling_velocity) OVERRIDE;
   virtual void DidStopFlinging() OVERRIDE {}
   virtual uint32 RendererFrameNumber() OVERRIDE;
   virtual void DidReceiveRendererFrame() OVERRIDE;

[jdduke (slow), 2014-04-28 21:45:48]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-28 21:46:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/20045007/115001

[commit-bot: I haz the power, 2014-04-28 23:11:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 23:11:14]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[jdduke (slow), 2014-04-28 23:22:39]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-28 23:25:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/20045007/115001

[commit-bot: I haz the power, 2014-04-29 00:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 00:19:47]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[jdduke (slow), 2014-04-29 02:08:01]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-29 02:09:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/20045007/115001

[commit-bot: I haz the power, 2014-04-29 09:37:58]

Change committed as 266805