Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2004493002: Add a mojo::RunApplication() for running implementations of ApplicationImplBase. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work790_environment_no_instantiate
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a mojo::RunApplication() for running implementations of ApplicationImplBase. Also add a mojo::TerminateApplication() that works with it. And convert some low-hanging fruit. The API probably isn't final yet: * As indicated by the TODO, RunApplication() should probably return a MojoResult. * Conversely, TerminateApplication() should probably take a MojoResult. * I should probably have an additional "RunMainApplication()" (MainRunApplication()?) for the main thread/MojoMain() case. * Then I can separate out the APIs from the implementation, and the "chromium" versions can implement the same API. * (The main/non-main cases are the same in the "standalone" case, but in the "chromium" version, the main case has to do more stuff.) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7d579155cc597aa3befcbfad66eef54bda06b57c

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -116 lines) Patch
M examples/echo/echo_benchmark.cc View 1 chunk +0 lines, -1 line 0 comments Download
M examples/spinning_cube/spinning_cube_app.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M examples/trace_me/trace_me_app.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/public/cpp/application/application_impl_base.h View 2 chunks +22 lines, -7 lines 0 comments Download
M mojo/public/cpp/application/lib/application_impl_base.cc View 2 chunks +11 lines, -2 lines 0 comments Download
A mojo/public/cpp/application/lib/run_application.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A mojo/public/cpp/application/run_application.h View 1 chunk +53 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 4 chunks +14 lines, -11 lines 0 comments Download
M mojo/services/log/cpp/log_client.h View 1 chunk +7 lines, -6 lines 0 comments Download
M services/test_service/test_request_tracker_application.h View 1 chunk +5 lines, -9 lines 0 comments Download
M services/test_service/test_request_tracker_application.cc View 2 chunks +8 lines, -18 lines 0 comments Download
M services/test_service/test_service_application.h View 1 chunk +4 lines, -11 lines 0 comments Download
M services/test_service/test_service_application.cc View 2 chunks +9 lines, -18 lines 0 comments Download
M services/test_service/test_service_impl.h View 3 chunks +1 line, -4 lines 0 comments Download
M services/test_service/test_service_impl.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M services/test_service/test_time_service_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M services/test_service/test_time_service_impl.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/1997473005/.
4 years, 7 months ago (2016-05-20 17:42:30 UTC) #1
viettrungluu
ping
4 years, 7 months ago (2016-05-23 17:57:03 UTC) #2
vardhan
lgtm
4 years, 7 months ago (2016-05-23 19:48:29 UTC) #3
viettrungluu
4 years, 7 months ago (2016-05-23 20:06:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7d579155cc597aa3befcbfad66eef54bda06b57c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698