Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2004463004: fixed #579, make DateTime use in the SDK typed (Closed)

Created:
4 years, 7 months ago by Jennifer Messerly
Modified:
4 years, 7 months ago
Reviewers:
Leaf, Alan Knight, sra1
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M lib/runtime/dart_sdk.js View 2 chunks +16 lines, -16 lines 0 comments Download
M tool/input_sdk/private/js_helper.dart View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
Alan was seeing a lot of dload isUtc show up hot
4 years, 7 months ago (2016-05-21 01:14:40 UTC) #2
Jennifer Messerly
Alan was seeing a lot of dload isUtc show up hot
4 years, 7 months ago (2016-05-21 01:14:43 UTC) #3
Leaf
lgtm
4 years, 7 months ago (2016-05-21 01:45:14 UTC) #4
Jennifer Messerly
4 years, 7 months ago (2016-05-23 16:16:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dac62b61ee9cd2bd411bd5bba47576b52804010d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698