Add a Dns preresolve interface in //content

content/browser/loader/resource_hints_impl.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_LOADER_RESOURCE_HINTS_IMPL_H_
+#define CONTENT_BROWSER_LOADER_RESOURCE_HINTS_IMPL_H_
+
+#include <set>
+
+#include "base/macros.h"
+#include "net/base/address_list.h"
+#include "net/dns/host_resolver.h"
+#include "net/dns/single_request_host_resolver.h"
+#include "net/url_request/url_request_context_getter.h"
+
+namespace content {
+
+// Scoped to the ResourceDispatcherHostImpl. This class manages DNS
+// preresolutions. Once resource hints go through mojo it will also respond to
+// mojo requests from Blink to preconnect / preresolve.
+class ResourceHintsController {

[kinuko, 2016/05/23 14:07:26]

I feel this class could be in its own header and cc file (e.g.
resource_hints_controller.{h,cc}

[Charlie Harrison, 2016/05/23 17:12:30]

Done.

+ public:
+  ResourceHintsController();
+  ~ResourceHintsController();
+  int PreresolveUrl(net::URLRequestContextGetter* getter,
+                    const GURL& url,
+                    const net::CompletionCallback& callback);
+
+ private:
+  struct DnsRequest {

[kinuko, 2016/05/23 14:07:26]

nit: the definition of this struct could be in .cc

[Charlie Harrison, 2016/05/23 17:12:30]

Done.

+    DnsRequest(net::HostResolver* resolver);

[kinuko, 2016/05/23 14:07:26]

nit: explicit

[Charlie Harrison, 2016/05/23 17:12:30]

Done.

+    net::SingleRequestHostResolver resolver;
+    net::AddressList addresses;
+  };
+
+  void OnResolveComplete(DnsRequest* request,
+                         const net::CompletionCallback& callback,
+                         int result);
+
+  std::set<DnsRequest*> pending_dns_requests_;

[kinuko, 2016/05/23 14:07:26]

std::set<std::unique_ptr<DnsRequest>> ?

[Charlie Harrison, 2016/05/23 17:12:30]

Is there an easy way to do this with unique pointers? I think the closest
approximation I could do is std::map<DnsRequest*, std::unique_ptr<DnsRequest>>.

The problem is that we need to lookup a DnsRequest* on OnResolveComplete.
Actually, let me try passing ownership to the callback. Then I don't even think
we need a container.

+
+  DISALLOW_COPY_AND_ASSIGN(ResourceHintsController);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_LOADER_RESOURCE_HINTS_IMPL_H_