Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2004433002: Retract GrRenderTarget from GrTestTarget (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Retract GrRenderTarget from GrTestTarget Split out of: https://codereview.chromium.org/1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=2004433002 Committed: https://skia.googlesource.com/skia/+/87f15c8ff11ad2bfb0c6711d7837020a50fe7fb8

Patch Set 1 #

Patch Set 2 : Fix bench build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -61 lines) Patch
M bench/GLBench.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gm/imagefromyuvtextures.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/rectangletexture.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 2 chunks +2 lines, -3 lines 0 comments Download
M include/gpu/GrDrawContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 2 chunks +29 lines, -29 lines 0 comments Download
M tools/gpu/GrTest.h View 2 chunks +4 lines, -6 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +5 lines, -23 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
robertphillips
4 years, 7 months ago (2016-05-20 15:31:27 UTC) #4
bsalomon
lgtm
4 years, 7 months ago (2016-05-20 15:37:45 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004433002/20001
4 years, 7 months ago (2016-05-20 16:14:03 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-20 16:34:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004433002/20001
4 years, 7 months ago (2016-05-20 18:13:23 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 18:14:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/87f15c8ff11ad2bfb0c6711d7837020a50fe7fb8

Powered by Google App Engine
This is Rietveld 408576698