third_party/WebKit/Source/bindings/core/v8/SourceLocation.h - Issue 2004423007: SourceLocation: Fix use-after-move.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

Issue 2004423007: SourceLocation: Fix use-after-move. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reflect review comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

index 0890401f4f57451fa226f5176a7a3dae9f3cae52..93c918f2b5a9077643f32993f4f661f63bea4bcc 100644

--- a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

+++ b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

@@ -28,6 +28,7 @@ public:

static PassOwnPtr<SourceLocation> fromMessage(v8::Isolate*, v8::Local<v8::Message>, ExecutionContext*);

static PassOwnPtr<SourceLocation> create(const String& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId = 0);

+ static PassOwnPtr<SourceLocation> createFromNonEmptyV8StackTrace(std::unique_ptr<V8StackTrace>, int scriptId = 0);

~SourceLocation();

bool isEmpty() const { return m_url.isNull(); }

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp » ('j') | no next file with comments »