Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2004423002: ⛅ Fix presubmit test for android. (Closed)

Created:
4 years, 7 months ago by Peter Wen
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix presubmit test for android. BUG=614340 Committed: https://crrev.com/4fbaab8fd469c94869f7ae1a0d0fa9cf4ec23b4a Cr-Commit-Position: refs/heads/master@{#395873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Peter Wen
⛎
4 years, 7 months ago (2016-05-24 12:35:09 UTC) #2
jbudorick
lgtm
4 years, 7 months ago (2016-05-24 12:37:25 UTC) #3
Peter Wen
+phajdan.jr@ for PRESUBMIT OWNERS.
4 years, 7 months ago (2016-05-24 13:05:16 UTC) #5
Paweł Hajdan Jr.
LGTM
4 years, 7 months ago (2016-05-25 01:43:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004423002/1
4 years, 7 months ago (2016-05-25 12:51:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 12:54:49 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 12:55:54 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4fbaab8fd469c94869f7ae1a0d0fa9cf4ec23b4a
Cr-Commit-Position: refs/heads/master@{#395873}

Powered by Google App Engine
This is Rietveld 408576698