Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2004403003: Build library for the Dart Content Handler. (Closed)

Created:
4 years, 7 months ago by nellyv
Modified:
4 years, 7 months ago
Reviewers:
nelly, qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Build library for the Dart Content Handler. This change will allow Manganese to use the dart content handler as a library. BUG= R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6638e8b4f21ba6cb51d9110e2f63d481a8304180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -324 lines) Patch
M services/dart/BUILD.gn View 2 chunks +16 lines, -2 lines 0 comments Download
A services/dart/content_handler_app.h View 1 chunk +74 lines, -0 lines 0 comments Download
A services/dart/content_handler_app.cc View 1 chunk +260 lines, -0 lines 0 comments Download
M services/dart/content_handler_main.cc View 1 chunk +1 line, -322 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nelly
Hi Ben, Ptal.
4 years, 7 months ago (2016-05-24 13:33:15 UTC) #2
qsr
lgtm
4 years, 7 months ago (2016-05-24 13:54:09 UTC) #3
nellyv
4 years, 7 months ago (2016-05-24 13:55:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6638e8b4f21ba6cb51d9110e2f63d481a8304180 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698