Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2004383002: OwnPtr: Add reset() as an alias of clear(). (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
tzik
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OwnPtr: Add reset() as an alias of clear(). We are planning to rename OwnPtr::clear() to reset(), as a part of OwnPtr -> std::unique_ptr migration. This patch adds a new member function reset() that is an alias of clear() in order to facilitate the rename process. Eventually reset() will take over clear(). BUG=611661 Committed: https://crrev.com/9e538ecb8f6819b5b39ec8146b9ae566f519a939 Cr-Commit-Position: refs/heads/master@{#395586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/wtf/OwnPtr.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Yuta Kitamura
PTAL?
4 years, 7 months ago (2016-05-24 08:36:21 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004383002/1
4 years, 7 months ago (2016-05-24 08:36:22 UTC) #5
tzik
lgtm
4 years, 7 months ago (2016-05-24 08:40:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 13:06:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004383002/1
4 years, 7 months ago (2016-05-24 13:24:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 13:28:12 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 13:29:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e538ecb8f6819b5b39ec8146b9ae566f519a939
Cr-Commit-Position: refs/heads/master@{#395586}

Powered by Google App Engine
This is Rietveld 408576698