Revert of [gn] Add unittests

Revert of [gn] Add unittests (patchset #4 id:60001 of https://codereview.chromium.org/2011853002/ )

Reason for revert:
Speculative revert because of roll block:
https://codereview.chromium.org/2004203004/

Original issue's description:
> [gn] Add unittests
>
> BUG=chromium:474921
> NOTRY=true
>
> Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e
> Cr-Commit-Position: refs/heads/master@{#36510}

TBR=vogelheim@chromium.org,bmeurer@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921
Committed: https://crrev.com/7ceb910103b5624fa3a85fbebca774a10847d173
Cr-Commit-Position: refs/heads/master@{#36521}

[Michael Hablich, 2016-05-25 15:15:55]

Created Revert of [gn] Add unittests

[commit-bot: I haz the power, 2016-05-25 15:16:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004373005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004373005/1

[commit-bot: I haz the power, 2016-05-25 15:16:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 15:16:13]

Failed to apply patch for BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: BUILD.gn:2021
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: BUILD.gn: patch does not apply

Patch:       BUILD.gn
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
f432d288f32de1e02ef2bef6a9d446e7f2be043b..6b2408e3f15da55234a5a33608a3b7dde7e9f32e
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -2021,33 +2021,6 @@
 # Public targets
 #
 
-want_v8_shell = (
-    (current_toolchain == host_toolchain && v8_toolset_for_shell == "host") ||
-    (current_toolchain == v8_snapshot_toolchain &&
-     v8_toolset_for_shell == "host") ||
-    (current_toolchain != host_toolchain && v8_toolset_for_shell == "target"))
-
-group("gn_all") {
-  testonly = true
-
-  deps = [
-    ":d8",
-  ]
-
-  if (want_v8_shell) {
-    deps += [
-      ":v8_shell",
-    ]
-  }
-
-  if (host_os != "mac" || !is_android) {
-    # These items don't compile for Android on Mac.
-    deps += [
-      "test/unittests:unittests",
-    ]
-  }
-}
-
 if (is_component_build) {
   component("v8") {
     sources = [
@@ -2120,7 +2093,10 @@
   }
 }
 
-if (want_v8_shell) {
+if ((current_toolchain == host_toolchain && v8_toolset_for_shell == "host") ||
+    (current_toolchain == v8_snapshot_toolchain &&
+     v8_toolset_for_shell == "host") ||
+    (current_toolchain != host_toolchain && v8_toolset_for_shell == "target"))
{
   executable("v8_shell") {
     sources = [
       "samples/shell.cc",

[Michael Hablich, 2016-05-25 15:20:12]

The CQ bit was checked by hablich@chromium.org

[commit-bot: I haz the power, 2016-05-25 15:20:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004373005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004373005/1

[commit-bot: I haz the power, 2016-05-25 15:21:01]

Description was changed from

==========
Revert of [gn] Add unittests (patchset #4 id:60001 of
https://codereview.chromium.org/2011853002/ )

Reason for revert:
Speculative revert because of roll block: 
https://codereview.chromium.org/2004203004/

Original issue's description:
> [gn] Add unittests
> 
> BUG=chromium:474921
> NOTRY=true
> 
> Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e
> Cr-Commit-Position: refs/heads/master@{#36510}

TBR=vogelheim@chromium.org,bmeurer@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921
==========

to

==========
Revert of [gn] Add unittests (patchset #4 id:60001 of
https://codereview.chromium.org/2011853002/ )

Reason for revert:
Speculative revert because of roll block: 
https://codereview.chromium.org/2004203004/

Original issue's description:
> [gn] Add unittests
> 
> BUG=chromium:474921
> NOTRY=true
> 
> Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e
> Cr-Commit-Position: refs/heads/master@{#36510}

TBR=vogelheim@chromium.org,bmeurer@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921
==========

[commit-bot: I haz the power, 2016-05-25 15:21:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-25 15:21:17]

Description was changed from

==========
Revert of [gn] Add unittests (patchset #4 id:60001 of
https://codereview.chromium.org/2011853002/ )

Reason for revert:
Speculative revert because of roll block: 
https://codereview.chromium.org/2004203004/

Original issue's description:
> [gn] Add unittests
> 
> BUG=chromium:474921
> NOTRY=true
> 
> Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e
> Cr-Commit-Position: refs/heads/master@{#36510}

TBR=vogelheim@chromium.org,bmeurer@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921
==========

to

==========
Revert of [gn] Add unittests (patchset #4 id:60001 of
https://codereview.chromium.org/2011853002/ )

Reason for revert:
Speculative revert because of roll block:
https://codereview.chromium.org/2004203004/

Original issue's description:
> [gn] Add unittests
>
> BUG=chromium:474921
> NOTRY=true
>
> Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e
> Cr-Commit-Position: refs/heads/master@{#36510}

TBR=vogelheim@chromium.org,bmeurer@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921

Committed: https://crrev.com/7ceb910103b5624fa3a85fbebca774a10847d173
Cr-Commit-Position: refs/heads/master@{#36521}
==========

[commit-bot: I haz the power, 2016-05-25 15:21:18]

Patchset 1 (id:??) landed as
https://crrev.com/7ceb910103b5624fa3a85fbebca774a10847d173
Cr-Commit-Position: refs/heads/master@{#36521}

[Michael Achenbach, 2016-05-27 06:12:31]

lgtm