Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2004363003: Only re-use an anonymous block for continuations if it's contained by a block flow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
szager1, wkorman, eae
CC:
chromium-reviews, cbiesinger, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only re-use an anonymous block for continuations if it's contained by a block flow. Be more strict about what kind of anonymous blocks we allow to be re-used for continuations. The deprecated flex box implementation would actually let items of a flexbox form a continuation chain. Continuations should only exist in block formatting contexts. This was discovered while attempting to land https://codereview.chromium.org/1997033002/ , which, it turns out, made some invalid assumptions about objects being block flows. BUG=302024 Committed: https://crrev.com/e0d355a173d0bae9c533fe49ef23258f263e9a8b Cr-Commit-Position: refs/heads/master@{#395614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
A third_party/WebKit/LayoutTests/fast/deprecated-flexbox/inline-with-block-child.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/deprecated-flexbox/inline-with-block-child-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +18 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-24 13:45:19 UTC) #2
eae
ok, LGTM
4 years, 7 months ago (2016-05-24 15:56:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004363003/1
4 years, 7 months ago (2016-05-24 16:05:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 16:51:50 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 16:53:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0d355a173d0bae9c533fe49ef23258f263e9a8b
Cr-Commit-Position: refs/heads/master@{#395614}

Powered by Google App Engine
This is Rietveld 408576698