Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: src/ast/ast-expression-visitor.h

Issue 2004363002: Refactor duplicate logic in Ast{Traversal,Expression}Visitor (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Undefine utility macros Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/ast.cc ('k') | src/ast/ast-expression-visitor.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_AST_AST_EXPRESSION_VISITOR_H_ 5 #ifndef V8_AST_AST_EXPRESSION_VISITOR_H_
6 #define V8_AST_AST_EXPRESSION_VISITOR_H_ 6 #define V8_AST_AST_EXPRESSION_VISITOR_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/ast/scopes.h" 10 #include "src/ast/scopes.h"
11 #include "src/type-info.h" 11 #include "src/type-info.h"
12 #include "src/zone.h" 12 #include "src/zone.h"
13 13
14 namespace v8 { 14 namespace v8 {
15 namespace internal { 15 namespace internal {
16 16
17 // A Visitor over a CompilationInfo's AST that invokes 17 // A Visitor over a CompilationInfo's AST that invokes
18 // VisitExpression on each expression node. 18 // VisitExpression on each expression node.
19 19
20 class AstExpressionVisitor : public AstVisitor { 20 class AstExpressionVisitor : public AstTraversalVisitor {
21 public: 21 public:
22 AstExpressionVisitor(Isolate* isolate, Expression* root); 22 AstExpressionVisitor(Isolate* isolate, Expression* root);
23 AstExpressionVisitor(uintptr_t stack_limit, Expression* root); 23 AstExpressionVisitor(uintptr_t stack_limit, Expression* root);
24 void Run(); 24 void Run();
25 25
26 protected: 26 protected:
27 virtual void VisitExpression(Expression* expression) = 0; 27 virtual void VisitExpression(Expression* expression) = 0;
28 int depth() { return depth_; }
29
30 void VisitDeclarations(ZoneList<Declaration*>* d) override;
31 void VisitStatements(ZoneList<Statement*>* s) override;
32 28
33 private: 29 private:
34 DEFINE_AST_VISITOR_SUBCLASS_MEMBERS();
35
36 #define DECLARE_VISIT(type) void Visit##type(type* node) override; 30 #define DECLARE_VISIT(type) void Visit##type(type* node) override;
37 AST_NODE_LIST(DECLARE_VISIT) 31 EXPRESSION_NODE_LIST(DECLARE_VISIT)
38 #undef DECLARE_VISIT 32 #undef DECLARE_VISIT
39 33
40 Expression* root_; 34 Expression* root_;
41 int depth_;
42 35
43 DISALLOW_COPY_AND_ASSIGN(AstExpressionVisitor); 36 DISALLOW_COPY_AND_ASSIGN(AstExpressionVisitor);
44 }; 37 };
45 } // namespace internal 38 } // namespace internal
46 } // namespace v8 39 } // namespace v8
47 40
48 #endif // V8_AST_AST_EXPRESSION_VISITOR_H_ 41 #endif // V8_AST_AST_EXPRESSION_VISITOR_H_
OLDNEW
« no previous file with comments | « src/ast/ast.cc ('k') | src/ast/ast-expression-visitor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698