Refactor duplicate logic in Ast{Traversal,Expression}Visitor

Refactor duplicate logic in Ast{Traversal,Expression}Visitor

Add stack overflow checks to AstTraversalVisitor, and let
AstExpressionVisitor reuse traversal logic from AstTraversalVisitor.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/eb488c1f8cb789671deb68359bee4e647c0984cf
Cr-Commit-Position: refs/heads/master@{#36500}

[jgruber, 2016-05-24 07:17:09]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 07:17:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004363002/1

[jgruber, 2016-05-24 07:49:17]

jgruber@chromium.org changed reviewers:
+ adamk@chromium.org

[commit-bot: I haz the power, 2016-05-24 07:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 07:53:12]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-05-24 17:16:48]

lgtm % nit

https://codereview.chromium.org/2004363002/diff/1/src/ast/ast.cc
File src/ast/ast.cc (right):

https://codereview.chromium.org/2004363002/diff/1/src/ast/ast.cc#newcode1114
src/ast/ast.cc:1114: }
Can you #undefine RECURSE and RECURSE_EXPRESSION here?

[jgruber, 2016-05-25 07:01:49]

https://codereview.chromium.org/2004363002/diff/1/src/ast/ast.cc
File src/ast/ast.cc (right):

https://codereview.chromium.org/2004363002/diff/1/src/ast/ast.cc#newcode1114
src/ast/ast.cc:1114: }
On 2016/05/24 17:16:48, adamk wrote:
> Can you #undefine RECURSE and RECURSE_EXPRESSION here?

Done.

[Yang, 2016-05-25 08:17:07]

lgtm

[jgruber, 2016-05-25 08:22:38]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-05-25 08:22:39]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2004363002/#ps20001
(title: "Undefine utility macros")

[commit-bot: I haz the power, 2016-05-25 08:22:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004363002/20001

[commit-bot: I haz the power, 2016-05-25 08:56:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-25 09:00:02]

Description was changed from

==========
Refactor duplicate logic in Ast{Traversal,Expression}Visitor

Add stack overflow checks to AstTraversalVisitor, and let
AstExpressionVisitor reuse traversal logic from AstTraversalVisitor.

R=yangguo@chromium.org
BUG=
==========

to

==========
Refactor duplicate logic in Ast{Traversal,Expression}Visitor

Add stack overflow checks to AstTraversalVisitor, and let
AstExpressionVisitor reuse traversal logic from AstTraversalVisitor.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/eb488c1f8cb789671deb68359bee4e647c0984cf
Cr-Commit-Position: refs/heads/master@{#36500}
==========

[commit-bot: I haz the power, 2016-05-25 09:00:03]

Patchset 2 (id:??) landed as
https://crrev.com/eb488c1f8cb789671deb68359bee4e647c0984cf
Cr-Commit-Position: refs/heads/master@{#36500}