Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2004343002: Remove unwanted copyToVector() uses. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unwanted copyToVector() uses. If a collection is being cleared while creating an iterable view of its current contents, swap in an empty collection rather than copy out the current contents into a temporary vector (by way of copyToVector().) R=tkent BUG= Committed: https://crrev.com/b0423799d4c45060338e6d7ac6db3a284f238aac Cr-Commit-Position: refs/heads/master@{#395547}

Patch Set 1 #

Patch Set 2 : remove unused typedef #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp View 1 2 chunks +2 lines, -5 lines 1 comment Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-24 07:10:15 UTC) #2
tkent
lgtm
4 years, 7 months ago (2016-05-24 07:13:51 UTC) #3
sof
https://codereview.chromium.org/2004343002/diff/20001/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp File third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp (left): https://codereview.chromium.org/2004343002/diff/20001/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp#oldcode12 third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp:12: typedef HeapVector<Member<IntersectionObserver>> IntersectionObserverVector; now unused, forgot to remove this ...
4 years, 7 months ago (2016-05-24 07:16:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004343002/20001
4 years, 7 months ago (2016-05-24 07:17:14 UTC) #8
haraken
LGTM
4 years, 7 months ago (2016-05-24 07:21:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 08:45:22 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 08:47:14 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0423799d4c45060338e6d7ac6db3a284f238aac
Cr-Commit-Position: refs/heads/master@{#395547}

Powered by Google App Engine
This is Rietveld 408576698