git_cl.py - Issue 2004303003: git cl upload: die when --no-squash has no commit-msg-hook.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 2004303003: git cl upload: die when --no-squash has no commit-msg-hook. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index af8b0a859f1eeb64cec19e6f5525b074847955eb..fef3de9a6bd74946ac11ddf1f4e99fec9e41a611 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -2523,7 +2523,7 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):

print 'git-cl: Added Change-Id to commit message.'

return new_log_desc

else:

- print >> sys.stderr, 'ERROR: Gerrit commit-msg hook not available.'

+ DieWithError('ERROR: Gerrit commit-msg hook not available.')

Bons 2016/05/24 15:22:36 would it better if instead of saying "available" i

tandrii(chromium) 2016/05/31 15:21:23 agree.

def SetCQState(self, new_state):

"""Sets the Commit-Queue label assuming canonical CQ config for Gerrit."""

« no previous file with comments | « no previous file | no next file » | no next file with comments »