git cl upload: die when --no-squash has no commit-msg-hook.

git cl upload: die when --no-squash has no commit-msg-hook.

Otherwise, the program continues, and an exception is printed.
The message is still there, but easy to miss.

R=andybons@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300674

[tandrii(chromium), 2016-05-24 09:20:45]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 09:20:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004303003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004303003/1

[commit-bot: I haz the power, 2016-05-24 09:24:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 09:24:02]

Dry run: This issue passed the CQ dry run.

[Bons, 2016-05-24 15:22:36]

lgtm

https://codereview.chromium.org/2004303003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2004303003/diff/1/git_cl.py#newcode2526
git_cl.py:2526: DieWithError('ERROR: Gerrit commit-msg hook not available.')
would it better if instead of saying "available" it said "installed"?

[tandrii(chromium), 2016-05-31 15:21:23]

https://codereview.chromium.org/2004303003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2004303003/diff/1/git_cl.py#newcode2526
git_cl.py:2526: DieWithError('ERROR: Gerrit commit-msg hook not available.')
On 2016/05/24 15:22:36, Bons wrote:
> would it better if instead of saying "available" it said "installed"?

agree.

[tandrii(chromium), 2016-05-31 15:21:26]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-05-31 15:21:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/2004303003/#ps20001
(title: "installed")

[commit-bot: I haz the power, 2016-05-31 15:21:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004303003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004303003/20001

[commit-bot: I haz the power, 2016-05-31 15:24:45]

Description was changed from

==========
git cl upload: die when --no-squash has no commit-msg-hook.

Otherwise, the program continues, and an exception is printed.
The message is still there, but easy to miss.

R=andybons@chromium.org
BUG=
==========

to

==========
git cl upload: die when --no-squash has no commit-msg-hook.

Otherwise, the program continues, and an exception is printed.
The message is still there, but easy to miss.

R=andybons@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300674
==========

[commit-bot: I haz the power, 2016-05-31 15:24:46]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300674