Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: icu.gyp

Issue 20043007: Only depend on libgabi++ for the target toolset. (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party/icu46/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'use_system_icu%': 0, 7 'use_system_icu%': 0,
8 'icu_use_data_file_flag%': 0, 8 'icu_use_data_file_flag%': 0,
9 'want_separate_host_toolset%': 1, 9 'want_separate_host_toolset%': 1,
10 }, 10 },
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 }], 335 }],
336 ['OS == "android" and clang==0', { 336 ['OS == "android" and clang==0', {
337 # Disable sincos() optimization to avoid a linker error since 337 # Disable sincos() optimization to avoid a linker error since
338 # Android's math library doesn't have sincos(). Either 338 # Android's math library doesn't have sincos(). Either
339 # -fno-builtin-sin or -fno-builtin-cos works. 339 # -fno-builtin-sin or -fno-builtin-cos works.
340 'cflags': [ 340 'cflags': [
341 '-fno-builtin-sin', 341 '-fno-builtin-sin',
342 ], 342 ],
343 }], 343 }],
344 ['OS == "android" and use_system_stlport == 1', { 344 ['OS == "android" and use_system_stlport == 1', {
345 # ICU requires RTTI, which is not present in the system's stlport, 345 'target_conditions': [
346 # so we have to include gabi++. 346 ['_toolset == "target"', {
347 'include_dirs': [ 347 # ICU requires RTTI, which is not present in the system's
348 '<(android_src)/abi/cpp/include', 348 # stlport, so we have to include gabi++.
349 'include_dirs': [
350 '<(android_src)/abi/cpp/include',
351 ],
352 'link_settings': {
353 'libraries': [
354 '-lgabi++',
355 ],
356 },
357 }],
349 ], 358 ],
350 'link_settings': {
351 'libraries': [
352 '-lgabi++',
353 ],
354 },
355 }], 359 }],
356 ], 360 ],
357 }, 361 },
358 { 362 {
359 'target_name': 'icuuc', 363 'target_name': 'icuuc',
360 'type': '<(component)', 364 'type': '<(component)',
361 'sources': [ 365 'sources': [
362 'source/common/bmpset.cpp', 366 'source/common/bmpset.cpp',
363 'source/common/brkeng.cpp', 367 'source/common/brkeng.cpp',
364 'source/common/brkiter.cpp', 368 'source/common/brkiter.cpp',
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 }, 563 },
560 }], 564 }],
561 ['OS == "win"', { 565 ['OS == "win"', {
562 'msvs_settings': { 566 'msvs_settings': {
563 'VCCLCompilerTool': { 567 'VCCLCompilerTool': {
564 'RuntimeTypeInfo': 'true', 568 'RuntimeTypeInfo': 'true',
565 }, 569 },
566 }, 570 },
567 }], 571 }],
568 ['OS == "android" and use_system_stlport == 1', { 572 ['OS == "android" and use_system_stlport == 1', {
569 # ICU requires RTTI, which is not present in the system's stlport, 573 'target_conditions': [
570 # so we have to include gabi++. 574 ['_toolset == "target"', {
571 'include_dirs': [ 575 # ICU requires RTTI, which is not present in the system's
572 '<(android_src)/abi/cpp/include', 576 # stlport, so we have to include gabi++.
577 'include_dirs': [
578 '<(android_src)/abi/cpp/include',
579 ],
580 'link_settings': {
581 'libraries': [
582 '-lgabi++',
583 ],
584 },
585 }],
573 ], 586 ],
574 'link_settings': {
575 'libraries': [
576 '-lgabi++',
577 ],
578 },
579 }], 587 }],
580 ['clang==1', { 588 ['clang==1', {
581 'xcode_settings': { 589 'xcode_settings': {
582 'WARNING_CFLAGS': [ 590 'WARNING_CFLAGS': [
583 # ICU uses its own deprecated functions. 591 # ICU uses its own deprecated functions.
584 '-Wno-deprecated-declarations', 592 '-Wno-deprecated-declarations',
585 # ICU prefers `a && b || c` over `(a && b) || c`. 593 # ICU prefers `a && b || c` over `(a && b) || c`.
586 '-Wno-logical-op-parentheses', 594 '-Wno-logical-op-parentheses',
587 # ICU has some `unsigned < 0` checks. 595 # ICU has some `unsigned < 0` checks.
588 '-Wno-tautological-compare', 596 '-Wno-tautological-compare',
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
855 'toolsets': ['target'], 863 'toolsets': ['target'],
856 }, { 864 }, {
857 'toolsets': ['host', 'target'], 865 'toolsets': ['host', 'target'],
858 }], 866 }],
859 ], 867 ],
860 }, 868 },
861 ], 869 ],
862 }], 870 }],
863 ], 871 ],
864 } 872 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698