Issue 20043003: Omnibox Logging: Record Whether the User Was on a Search Results Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20043003: Omnibox Logging: Record Whether the User Was on a Search Results Page (Closed)

Created:
7 years, 5 months ago by Mark P

Modified:
7 years, 4 months ago

Reviewers:

CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Omnibox Logging: Record Whether the User Was on a Search Results Page More precisely, record whether the user was on a search result page NOT doing search term replacement. https://codereview.chromium.org/19810002/ covered the case when the page was doing search term replacement. This has been approved by chrome-privacy. BUG=251484

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -0 lines)			Patch
M	chrome/browser/ui/omnibox/omnibox_current_page_delegate.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_edit_model.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/metrics/proto/omnibox_event.proto	View	1 chunk	+3 lines, -0 lines	0 comments	Download