Rename fwl_widgetmgrimp.{cpp,h} to cfwl_widgetmgr.{cpp,h}

Rename fwl_widgetmgrimp.{cpp,h} to cfwl_widgetmgr.{cpp,h}

Committed: https://pdfium.googlesource.com/pdfium/+/648575aaa8989be7071e7ec61293470a44cf2d94

[Tom Sepez, 2016-05-24 18:30:03]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-05-24 18:30:06]

Lei, for review.

[dsinclair, 2016-05-24 19:19:35]

dsinclair@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-05-24 19:19:36]

https://codereview.chromium.org/2004293004/diff/40001/xfa/fwl/core/cfwl_widge...
File xfa/fwl/core/cfwl_widgetmgr.h (right):

https://codereview.chromium.org/2004293004/diff/40001/xfa/fwl/core/cfwl_widge...
xfa/fwl/core/cfwl_widgetmgr.h:128: class CFWL_WidgetMgrDelegate {
Should we pull this and the WidgetMgrItem out to their own files?

[Lei Zhang, 2016-05-24 19:30:26]

https://codereview.chromium.org/2004293004/diff/40001/xfa/fwl/core/cfwl_widge...
File xfa/fwl/core/cfwl_widgetmgr.h (right):

https://codereview.chromium.org/2004293004/diff/40001/xfa/fwl/core/cfwl_widge...
xfa/fwl/core/cfwl_widgetmgr.h:128: class CFWL_WidgetMgrDelegate {
On 2016/05/24 19:19:36, dsinclair wrote:
> Should we pull this and the WidgetMgrItem out to their own files?

How strict are we about one class per file? Or can related delgates / interfaces
go in the same file?

I don't think anyone uses CFWL_WidgetMgrItem outside of CFWL_WidgetMgr.

https://codereview.chromium.org/2004293004/diff/40001/xfa/fwl/core/cfwl_widge...
xfa/fwl/core/cfwl_widgetmgr.h:130: CFWL_WidgetMgrDelegate(CFWL_WidgetMgr*
pWidgetMgr);
explicit

[dsinclair, 2016-05-24 19:34:38]

https://codereview.chromium.org/2004293004/diff/40001/xfa/fwl/core/cfwl_widge...
File xfa/fwl/core/cfwl_widgetmgr.h (right):

https://codereview.chromium.org/2004293004/diff/40001/xfa/fwl/core/cfwl_widge...
xfa/fwl/core/cfwl_widgetmgr.h:128: class CFWL_WidgetMgrDelegate {
On 2016/05/24 19:30:26, Lei Zhang wrote:
> On 2016/05/24 19:19:36, dsinclair wrote:
> > Should we pull this and the WidgetMgrItem out to their own files?
> 
> How strict are we about one class per file? Or can related delgates /
interfaces
> go in the same file?
> 
> I don't think anyone uses CFWL_WidgetMgrItem outside of CFWL_WidgetMgr.


I've been pulling them out to their own files to try to get to one per file.
Makes it easier it find things if you can just open the file instead of guessing
where it lives.

Could WigetMgrItem could move to the cpp anonymous namespace then?

[Tom Sepez, 2016-05-24 21:29:51]

https://codereview.chromium.org/2004293004/diff/40001/xfa/fwl/core/cfwl_widge...
File xfa/fwl/core/cfwl_widgetmgr.h (right):

https://codereview.chromium.org/2004293004/diff/40001/xfa/fwl/core/cfwl_widge...
xfa/fwl/core/cfwl_widgetmgr.h:128: class CFWL_WidgetMgrDelegate {
On 2016/05/24 19:19:36, dsinclair wrote:
> Should we pull this and the WidgetMgrItem out to their own files?

No, these should really be nested classes, CFWL_WidgetMgr::Delegate and
CFWL_WidgetMgr::Item.  But it changes in a lot of places, should be its own CL.

https://codereview.chromium.org/2004293004/diff/40001/xfa/fwl/core/cfwl_widge...
xfa/fwl/core/cfwl_widgetmgr.h:130: CFWL_WidgetMgrDelegate(CFWL_WidgetMgr*
pWidgetMgr);
On 2016/05/24 19:30:26, Lei Zhang wrote:
> explicit

Done.

[dsinclair, 2016-05-25 18:40:01]

lgtm

[Tom Sepez, 2016-05-25 22:00:38]

On 2016/05/25 18:40:01, dsinclair wrote:
> lgtm

Lei, are you happy here?

[Lei Zhang, 2016-05-25 22:10:38]

lgtm

[Tom Sepez, 2016-05-25 22:12:08]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-05-25 22:12:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004293004/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004293004/50001

[commit-bot: I haz the power, 2016-05-25 22:24:34]

Description was changed from

==========
Rename fwl_widgetmgrimp.{cpp,h} to cfwl_widgetmgr.{cpp,h}
==========

to

==========
Rename fwl_widgetmgrimp.{cpp,h} to cfwl_widgetmgr.{cpp,h}

Committed:
https://pdfium.googlesource.com/pdfium/+/648575aaa8989be7071e7ec61293470a44cf...
==========

[commit-bot: I haz the power, 2016-05-25 22:24:35]

Committed patchset #4 (id:50001) as
https://pdfium.googlesource.com/pdfium/+/648575aaa8989be7071e7ec61293470a44cf...