Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: media/base/audio_renderer_mixer_input.cc

Issue 2004283002: AudioConverter: Express delay in frames rather than msec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed files & removed rounding Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/audio_renderer_mixer_input.h ('k') | media/base/audio_renderer_mixer_input_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_renderer_mixer_input.cc
diff --git a/media/base/audio_renderer_mixer_input.cc b/media/base/audio_renderer_mixer_input.cc
index 55dbfc8404f76d012cc8550ce2e45f16f7f0bec0..f748749cb5588e40cd9b7244343e97ccb6df1b52 100644
--- a/media/base/audio_renderer_mixer_input.cc
+++ b/media/base/audio_renderer_mixer_input.cc
@@ -160,13 +160,7 @@ void AudioRendererMixerInput::SwitchOutputDevice(
}
double AudioRendererMixerInput::ProvideInput(AudioBus* audio_bus,
- base::TimeDelta buffer_delay) {
- // TODO(chcunningham): Delete this conversion and change ProvideInput to more
- // precisely describe delay as a count of frames delayed instead of TimeDelta.
- // See http://crbug.com/587522.
- uint32_t frames_delayed = std::round(buffer_delay.InMicroseconds() /
- params_.GetMicrosecondsPerFrame());
-
+ uint32_t frames_delayed) {
int frames_filled = callback_->Render(audio_bus, frames_delayed, 0);
// AudioConverter expects unfilled frames to be zeroed.
« no previous file with comments | « media/base/audio_renderer_mixer_input.h ('k') | media/base/audio_renderer_mixer_input_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698