Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: media/base/audio_renderer_mixer.cc

Issue 2004283002: AudioConverter: Express delay in frames rather than msec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed files & removed rounding Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/audio_converter_unittest.cc ('k') | media/base/audio_renderer_mixer_input.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_renderer_mixer.cc
diff --git a/media/base/audio_renderer_mixer.cc b/media/base/audio_renderer_mixer.cc
index 10a19cded57347cfc31fc10a901050c680f671f6..c58b1e3572479681a302c2d140af275906e1bdb1 100644
--- a/media/base/audio_renderer_mixer.cc
+++ b/media/base/audio_renderer_mixer.cc
@@ -135,13 +135,7 @@ int AudioRendererMixer::Render(AudioBus* audio_bus,
playing_ = false;
}
- // TODO(chcunningham): Delete this conversion and change ConvertWith delay to
- // expect a count of frames delayed instead of TimeDelta (less precise).
- // See http://crbug.com/587522.
- base::TimeDelta audio_delay = base::TimeDelta::FromMicroseconds(
- std::round(frames_delayed * output_params_.GetMicrosecondsPerFrame()));
-
- master_converter_.ConvertWithDelay(audio_delay, audio_bus);
+ master_converter_.ConvertWithDelay(frames_delayed, audio_bus);
return audio_bus->frames();
}
« no previous file with comments | « media/base/audio_converter_unittest.cc ('k') | media/base/audio_renderer_mixer_input.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698