Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: media/audio/virtual_audio_output_stream.cc

Issue 2004283002: AudioConverter: Express delay in frames rather than msec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/virtual_audio_output_stream.cc
diff --git a/media/audio/virtual_audio_output_stream.cc b/media/audio/virtual_audio_output_stream.cc
index 1740b405d17c36069271113b534453b05f8f51f1..75980b252bb23433f1841a3a96019e1c6e862d75 100644
--- a/media/audio/virtual_audio_output_stream.cc
+++ b/media/audio/virtual_audio_output_stream.cc
@@ -74,15 +74,14 @@ void VirtualAudioOutputStream::GetVolume(double* volume) {
}
double VirtualAudioOutputStream::ProvideInput(AudioBus* audio_bus,
- base::TimeDelta buffer_delay) {
+ uint32_t frames_delayed) {
// Note: This method may be invoked on any one thread, depending on the
// platform.
DCHECK(callback_);
- DCHECK_GE(buffer_delay, base::TimeDelta());
- const int64_t upstream_delay_in_bytes = params_.GetBytesPerSecond() *
- buffer_delay /
- base::TimeDelta::FromSeconds(1);
+ DCHECK_GE(frames_delayed, 0U);
+ const int64_t upstream_delay_in_bytes =
DaleCurtis 2016/05/24 20:27:02 Mixing of int64_t + uint32_t seems unusual?
chcunningham 2016/05/25 18:21:14 Made int64_t -> uint32_t. Not really sure why it w
+ std::round(params_.GetBytesPerFrame() * frames_delayed);
const int frames = callback_->OnMoreData(
audio_bus, static_cast<uint32_t>(upstream_delay_in_bytes), 0);
if (frames < audio_bus->frames())

Powered by Google App Engine
This is Rietveld 408576698