AudioConverter: Express delay in frames rather than msec.

media/audio/virtual_audio_output_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/virtual_audio_output_stream.h"
 
 #include <stdint.h>
 
 #include "base/logging.h"
 #include "media/audio/virtual_audio_input_stream.h"
@@ skipping 56 matching lines @@
   DCHECK(thread_checker_.CalledOnValidThread());
   volume_ = volume;
 }
 
 void VirtualAudioOutputStream::GetVolume(double* volume) {
   DCHECK(thread_checker_.CalledOnValidThread());
   *volume = volume_;
 }
 
 double VirtualAudioOutputStream::ProvideInput(AudioBus* audio_bus,
-                                              base::TimeDelta buffer_delay) {
+                                              uint32_t frames_delayed) {
   // Note: This method may be invoked on any one thread, depending on the
   // platform.
   DCHECK(callback_);
 
-  DCHECK_GE(buffer_delay, base::TimeDelta());
-  const int64_t upstream_delay_in_bytes = params_.GetBytesPerSecond() *
-                                          buffer_delay /
-                                          base::TimeDelta::FromSeconds(1);
-  const int frames = callback_->OnMoreData(
-      audio_bus, static_cast<uint32_t>(upstream_delay_in_bytes), 0);
+  const uint32_t upstream_delay_in_bytes =
+      std::round(params_.GetBytesPerFrame() * frames_delayed);

[miu, 2016/05/25 21:41:06]

Doesn't seem that std::round() is required since this is all integer math.

[chcunningham, 2016/05/25 22:10:43]

Done.

+  const int frames =
+      callback_->OnMoreData(audio_bus, upstream_delay_in_bytes, 0);

[miu, 2016/05/25 21:41:06]

I can't wait for OnMoreData() to take |frames_delayed| instead of
|upstream_delay_in_bytes|!  :-)

[chcunningham, 2016/05/25 22:10:43]

Woot, me neither.

   if (frames < audio_bus->frames())
     audio_bus->ZeroFramesPartial(frames, audio_bus->frames() - frames);
 
   return frames > 0 ? volume_ : 0;
 }
 
 }  // namespace media