Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2004263002: [Do not commit] MD History: Experimentally implement cr-toolbar using cr-search-field (Closed)

Created:
4 years, 7 months ago by tsergeant
Modified:
4 years, 7 months ago
Reviewers:
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Do not commit] MD History: Experimentally implement cr-toolbar using cr-search-field BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -123 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 4 chunks +8 lines, -60 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.js View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/md_history/history_toolbar_test.js View 1 chunk +1 line, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_search_field/compiled_resources2.gyp View 1 chunk +8 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_search_field/cr_search_field.css View 2 chunks +22 lines, -19 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html View 2 chunks +14 lines, -14 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js View 7 chunks +30 lines, -14 lines 0 comments Download
A ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.html View 1 chunk +1 line, -0 lines 0 comments Download
A ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js View 1 chunk +13 lines, -0 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_toolbar/compiled_resources2.gyp View 1 chunk +2 lines, -3 lines 0 comments Download
A ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html View 1 chunk +132 lines, -0 lines 1 comment Download
A ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js View 1 chunk +41 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tsergeant
4 years, 7 months ago (2016-05-24 00:37:28 UTC) #2 
https://codereview.chromium.org/2004263002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html (right):

https://codereview.chromium.org/2004263002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html:10: <style>
TODO:

* blur closes the search field
* correct color for icon and prompt
* correct padding to left of icon
* correct styling of clear search button
* correct sizing of input text
* fire delegate callbacks correctly

Powered by Google App Engine
This is Rietveld 408576698