third_party/WebKit/Source/web/WebPepperSocketImpl.cpp - Issue 2004243002: Migrate websockets from url+lineNumber to SourceLocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPepperSocketImpl.cpp

Issue 2004243002: Migrate websockets from url+lineNumber to SourceLocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@more-source-location-1

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp ('K') | « third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebPepperSocketImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPepperSocketImpl.cpp b/third_party/WebKit/Source/web/WebPepperSocketImpl.cpp

index f424a56eb35720129c92b8753d79e7ded0f82c81..460456b9a6b151f26fd5567017d3c7f8462cd49c 100644

--- a/third_party/WebKit/Source/web/WebPepperSocketImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPepperSocketImpl.cpp

@@ -54,7 +54,7 @@ WebPepperSocketImpl::WebPepperSocketImpl(const WebDocument& document, WebPepperS

, m_bufferedAmountAfterClose(0)

{

Document* coreDocument = document;

- m_private = DocumentWebSocketChannel::create(coreDocument, m_channelProxy.get());

+ m_private = DocumentWebSocketChannel::create(coreDocument, m_channelProxy.get(), SourceLocation::capture());

}

WebPepperSocketImpl::~WebPepperSocketImpl()

@@ -140,7 +140,7 @@ void WebPepperSocketImpl::close(int code, const WebString& reason)

void WebPepperSocketImpl::fail(const WebString& reason)

{

- m_private->fail(reason, ErrorMessageLevel, String(), 0);

+ m_private->fail(reason, ErrorMessageLevel, nullptr);

}

void WebPepperSocketImpl::disconnect()